search

lavacord / Lavacord

A easy to use Lavalink client that can be used with any discord api wrapper
Apache License 2.0
78 stars 21 forks source link

configureResuming OP dropped if sent too early #94

Closed PapiOphidian closed 1 year ago

PapiOphidian commented 3 years ago

Lavalink seems to drop the configureResuming OP if it was sent too early even after websocket open. I did verify that the configureResuming method was being called and that the data was sent over the websocket. In testing, I found that waiting 5000ms (I did not test lower timeout durations), then attempting to configureResuming works as intended.

Before implementing a timeout before calling the configureResuming, I noticed some strange behavior; If the configureResuming method was called at a later time, the OP would go through and resuming would be configured properly. If you disconnect and reconnect within the resume timeout duration, configureResuming would work as intended. If the client fails to reconnect within the configured resume timeout, but attempts to configureResuming outside of that window, the OP would be dropped again.

PapiOphidian commented 1 year ago

It looks like this was being tracked on LavaLink's end and I think they have already fixed it.