search

lavalink-devs / lavaplayer

Lavaplayer fork maintained by Lavalink
Apache License 2.0
187 stars 51 forks source link

Fix NicoNico Regex #61

Closed a9lim closed 10 months ago

a9lim commented 10 months ago

Some NicoNico video IDs do not start with "sm" (e.g. https://www.nicovideo.jp/watch/nm14296458)

a9lim commented 10 months ago

Misunderstood what you meant by cherry pick, sorry!

topi314 commented 10 months ago

since we squashed your previous pr your main branch has way more commits than ours, that's we usually develop in so called feature branches. I recommend you force push our main branch to your & apply the changes again in a new feature branch based of your main branch then & reopen the pr from said branch

a9lim commented 10 months ago

Tried force pushing but ended up keeping it all in my main - hope that's ok

topi314 commented 10 months ago

works for me as long as I have one commit