lavaloon-eg / ksa_compliance

KSA Compliance App for KSA E-invoice
https://www.lavaloon.com/
GNU Affero General Public License v3.0
30 stars 18 forks source link

The file path for the certificate and the CLI are missing after the any deployment on frappe cloud #118

Open omarashrafsarhan opened 1 week ago

omarashrafsarhan commented 1 week ago

After any deployment or update on the instance using frappe cloud, the file paths for the KSA compliance app’s CLI and certificate are reset. This causes errors for users, requiring them to re-download the CLI and re-create the certificate, forcing them to go through the onboarding process again.

Preconditions

Repro Steps

  1. Open ZATCA business settings.
  2. Onboard a company.
  3. Create a sales invoice for the onboarded company.
  4. Perform an update or deployment on the instance.
  5. Attempt to create a new sales invoice for the onboarded company.

Actual results

  1. The user receives an error related to the missing CLI file path, prompting them to download it again.
  2. After downloading the CLI, another error related to the missing certificate path is displayed.

Expected Results

  1. The file paths for the CLI and certificate should be saved in the database.
  2. These file paths should persist through any deployment or update without requiring the user to re-download or re-enter information.
  3. No errors should be displayed when creating new sales invoices after deployment.
meaziz commented 5 days ago

Same happens upon auto update..