lavaloon-eg / ksa_compliance

KSA Compliance App for KSA E-invoice
https://www.lavaloon.com/
GNU Affero General Public License v3.0
37 stars 31 forks source link

Server Error While checking Compliance #80

Closed RAhmed-Dev closed 2 months ago

RAhmed-Dev commented 3 months ago

While checking Compliant I am getting this server error on local setup.

WhatsApp Image 2024-08-02 at 16 51 25_2e6dcfbd

I have configured the Additional ID's in the Customer.

mhaggag commented 3 months ago

Hello. Does this happen as soon as you press the "Perform compliance checks" button, or after picking the customers in the pop-up dialog? Does the customer have a VAT registration number added, or just additional IDs?

RAhmed-Dev commented 3 months ago

hello,

This happens when I try to select a Simplified Tax Customer and system shows this error. This customer does have Tax ID setup.

image

App Version: image

Yazan01H commented 3 months ago

I face the same problem as soon as I click on perform compliance checks what is the solution

mhaggag commented 3 months ago

hello,

This happens when I try to select a Simplified Tax Customer and system shows this error. This customer does have Tax ID setup.

This looks to be a bug in the query filter for customers. It looks like there's an edge case that's not handled properly resulting in the SQL error. I'll look into it and get back to you.

Note that the pop-up dialog has query filters configured to fetch customers without VAT information as "Simplified Customers" (for simplified tax invoices) and those with VAT information as "Standard Customers" (for standard tax invoices). Although the filter currently uses the custom field "VAT Registration Number" (custom_vat_registration_number) instead of the standard tax ID field.

saud-2 commented 3 months ago

Maybe the reason of error because Erpnext version 14 is not supported by app.

RAhmed-Dev commented 3 months ago

I found a user manual video for this app config.

So it does support v14 and v15.

https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://m.youtube.com/watch%3Fv%3DyrB77VQvLiU&ved=2ahUKEwjR_PrCv-WHAxVTRvEDHe7VAwAQtwJ6BAgQEAE&usg=AOvVaw2QbfV_bsVly0tCmHv4l_Ia

Ahmed-M-Fawzy commented 3 months ago

I found a user manual video for this app config.

So it does support v14 and v15.

https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://m.youtube.com/watch%3Fv%3DyrB77VQvLiU&ved=2ahUKEwjR_PrCv-WHAxVTRvEDHe7VAwAQtwJ6BAgQEAE&usg=AOvVaw2QbfV_bsVly0tCmHv4l_Ia

The video referenced was created using ERPNext version 15. The application does not support earlier versions, such as 14 or 13. Therefore, please upgrade ERPNext to version 15 first, and then install the application.

RAhmed-Dev commented 2 months ago

@Ahmed-M-Fawzy I have tried with V15,

now I am getting this error.

image

Version details: image

mhaggag commented 2 months ago

That looks to be an error message from the ZATCA SDK when validating the company location passed in the CSR configuration. We use the company address for that. Can you share what the address looks like in the "Seller Details" tab?

You can also check logs/zatca.log to see the CSR details we send to the ZATCA SDK. Look for csr.location.address

Ahmed-M-Fawzy commented 2 months ago

[surprised] Ahmed Fawzy reacted to your message:


From: Rizwan Ahmed @.> Sent: Monday, August 12, 2024 7:49:07 AM To: lavaloon-eg/ksa_compliance @.> Cc: Ahmed Fawzy @.>; Mention @.> Subject: Re: [lavaloon-eg/ksa_compliance] Server Error While checking Compliance (Issue #80)

@Ahmed-M-Fawzyhttps://github.com/Ahmed-M-Fawzy I have tried with V15,

now I am getting this error.

image.png (view on web)https://github.com/user-attachments/assets/35b395b4-216f-4017-bd69-4723c2abd07c

Version details: image.png (view on web)https://github.com/user-attachments/assets/dda2cdb0-0557-466b-98de-eb201abc0356

— Reply to this email directly, view it on GitHubhttps://github.com/lavaloon-eg/ksa_compliance/issues/80#issuecomment-2283308621, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW7ILY6WV5GOOV7QOZJ6MVTZRBSHHAVCNFSM6AAAAABL4PUSZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGMYDQNRSGE. You are receiving this because you were mentioned.Message ID: @.***>

RAhmed-Dev commented 2 months ago

@mhaggag @Ahmed-M-Fawzy Thank you Both, you have been a great help.

The issue was indeed with the address line 1. I remove the special character, and now its is working fine, image

This app is working well on erpnext v15.

I got this error, but this is related to customer Information, I will correct that and try again. image

Thanks for your support.