coderabbitai[bot]
commented
1 month ago Walkthrough
The recent updates significantly enhance the handling of Quality of Service (QoS) reports across the system. By integrating raw data alongside processed reports, these changes improve the accuracy and granularity of provider performance evaluations. New parameters and fields facilitate a more nuanced approach to session management and reputational updates, ultimately refining the evaluation processes essential for maintaining service quality.
Changes
| Files | Change Summary |
|---|---|
protocol/lavasession/.../consumer_session_manager.goprotocol/lavasession/.../consumer_types.go |
Improved QoS report handling by modifying method signatures to return both processed and raw reports. Added fields for enhanced tracking of provider performance metrics. |
protocol/provideroptimizer/.../provider_optimizer.goprotocol/provideroptimizer/.../provider_optimizer_test.go |
Expanded ProviderData structure with raw score fields and adjusted methods to return both processed and raw scores, enhancing performance evaluations and test coverage. |
utils/score/decay_score.go |
Updated score calculation methods to return both normalized and raw score instances, enhancing score management accuracy and facilitating clear distinctions between score types. |
Sequence Diagram(s)
sequenceDiagram
participant C as ConsumerSessionManager
participant P as ProviderOptimizer
participant S as SingleConsumerSession
participant R as RequestBuilder
C->>P: Request QoS Reports
P->>C: Return (QoSReport, RawQoSReport)
C->>S: SetUsageForSession(QoSReport, RawQoSReport)
S->>R: ConstructRelaySession(RawQoSReport)
R->>C: Return RelaySessionPoem
🐇 In the meadow, changes bloom,
With data bright, we clear the gloom!
QoS now dances, metrics in sight,
For providers and sessions, all feels right!
Hop, hop, hooray for the updates dear,
A new dawn breaks, let’s give a cheer! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
github-actions[bot]
Description
Closes: #XXXX
In this PR I've added another method of calculating QoS excellence that will generate a report that will replace the current QoS excellence report sent to the node upon relay payment. The "new" report, called raw QoS excellence, doesn't influence anything else - it only replaces the data sent to the node
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Tests