lavanet / lava

Apache License 2.0
404 stars 207 forks source link

[Bug]: Lavavisor auto-upgrade flow cannot download archive #1644

Closed sigv closed 2 weeks ago

sigv commented 3 weeks ago

Is there an existing issue for this?

What happened?

Experienced:

INF [Lavavisor] Started Version Upgrade flow
INF [Lavavisor] Update detected. Lavavisor starting the auto-upgrade...
INF [Lavavisor] Trying to fetch version=2.4.0
INF [Lavavisor] Version Directory versionDir=/home/lava/.lavavisor/upgrades/v2.4.0
DBG [Lavavisor] Handling missing version dir versionDir=/home/lava/.lavavisor/upgrades/v2.4.0
INF [Lavavisor] Version directory does not exist, but auto-download is enabled. Attempting to download binary from GitHub...
INF [Lavavisor] creating directory: /home/lava/.lavavisor/upgrades/v2.4.0
INF [Lavavisor] created /home/lava/.lavavisor/upgrades/v2.4.0 successfully
INF [Lavavisor] Trying to download: Version="&{Major:2 Minor:4 Patch:0}"
INF [Lavavisor] Fetching the source from:  URL=https://github.com/lavanet/lava/v2/archive/refs/tags/v2.4.0.zip
ERR [Lavavisor] bad HTTP status status="404 Not Found"
INF [Lavavisor] Failed downloading, deleting directory, retrying next block Version="&{Major:2 Minor:4 Patch:0}"
ERR [Lavavisor] Failed to auto-download binary from GitHub

Expected:

INF [Lavavisor] Started Version Upgrade flow
INF [Lavavisor] Update detected. Lavavisor starting the auto-upgrade...
INF [Lavavisor] Trying to fetch version=2.4.0
INF [Lavavisor] Version Directory versionDir=/home/lava/.lavavisor/upgrades/v2.4.0
DBG [Lavavisor] Handling missing version dir versionDir=/home/lava/.lavavisor/upgrades/v2.4.0
INF [Lavavisor] Version directory does not exist, but auto-download is enabled. Attempting to download binary from GitHub...
INF [Lavavisor] creating directory: /home/lava/.lavavisor/upgrades/v2.4.0
INF [Lavavisor] created /home/lava/.lavavisor/upgrades/v2.4.0 successfully
INF [Lavavisor] Trying to download: Version="&{Major:2 Minor:4 Patch:0}"
INF [Lavavisor] Fetching the source from:  URL=https://github.com/lavanet/lava/archive/refs/tags/v2.4.0.zip
INF [Lavavisor] Unzipping...

Lava Version

main

How to reproduce?

Start lavavisor allowing it to auto-upgrade/automatically download lavap.

sigv commented 2 weeks ago

To anyone stumbling upon this: The fix was included in main as 649e857834e8fb716479cf03d6efd20aec2c2b2b, and is expected to be released as v2.6.0.