Closed sigv closed 2 months ago
I do not see any way that changing the download URL could unexpectedly cause conflict handler to fire twice. The test case failure is reproducible locally with go test -race ./protocol/integration
, so there appears to be a flaky test:
panic: sync: negative WaitGroup counter
goroutine 35237 [running]:
sync.(*WaitGroup).Add(0xc022fe22e8?, 0x14?)
/opt/hostedtoolcache/go/1.20.14/x64/src/sync/waitgroup.go:62 +0xe5
sync.(*WaitGroup).Done(...)
/opt/hostedtoolcache/go/1.20.14/x64/src/sync/waitgroup.go:87
github.com/lavanet/lava/v2/protocol/integration.TestSameProviderConflictReport.func5.1({0xc028e30790?, 0xc02d1ed450?}, 0xc0285068a0, 0x7aa7fe?, {0xc0280f8d80?, 0x0?})
/home/runner/work/lava/lava/protocol/integration/protocol_test.go:1117 +0x2e5
github.com/lavanet/lava/v2/protocol/integration.(*mockConsumerStateTracker).TxConflictDetection(0xc022ac2fd0?, {0x380fd68?, 0xc0de325da0?}, 0x380fd30?, 0xc0271a82a0?, {0x37ee338?, 0xc026008240?})
/home/runner/work/lava/lava/protocol/integration/mocks.go:55 +0x48
created by github.com/lavanet/lava/v2/protocol/rpcconsumer.(*RPCConsumerServer).relayInner
/home/runner/work/lava/lava/protocol/rpcconsumer/rpcconsumer_server.go:1071 +0xc8e
FAIL github.com/lavanet/lava/v2/protocol/integration 17.444s
great catch @sigv thanks
Description
Closes: #1644
There was a mass-replacement for Lava v2 in commit 5864b7a. This resulted in the auto-download link being broken for Lavavisor. With this commit, the archive downloads can be successful again.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changemain
branchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...