search

lavary / crunz

A PHP-based job scheduler
MIT License
1.42k stars 136 forks source link

Symfony 6 Support #390

Closed bashgeek closed 2 years ago

bashgeek commented 2 years ago

Fixes #389

Added Symfony 6 versions to composer.json and fixed some type hints that are now required. All tests run fine after.

PabloKowalczyk commented 2 years ago

Could you add Symfony 6 checks to strategy matrix in .github/workflows/code_checks.yaml and change target branch to 3.2 (https://github.com/lavary/crunz/tree/3.2)?

bashgeek commented 2 years ago

Could you add Symfony 6 checks to strategy matrix in .github/workflows/code_checks.yaml and change target branch to 3.2 (https://github.com/lavary/crunz/tree/3.2)?

Done!

PabloKowalczyk commented 2 years ago

For some reason Windows build failed and could rebase your branch on 3.2?

bashgeek commented 2 years ago

For some reason Windows build failed and could rebase your branch on 3.2?

Seems to be an (newly introduced?) issue with the shivammathur/setup-php@v2 runtime: https://github.com/lavary/crunz/runs/4453789755?check_suite_focus=true#step:3:12

Had nothing to do with the changes made by me (didn't touch that part), it ran through fine in my workflow for the last commit (which is identical): https://github.com/bashgeek/crunz/runs/4451594357?check_suite_focus=true

Maybe just try to rerun those workflows?

PabloKowalczyk commented 2 years ago

Sorry for that, but you started your branch on master and you have commit https://github.com/lavary/crunz/pull/390/commits/ab7c590a0c7403043803bde733a9d281eecce19f which shouldn't be there, also i plan to remove master branch. This is why there are changelog and readme changes. Could you remove mentioned commit?

You are right, looks like Windows CI fails are not related to your changes.

bashgeek commented 2 years ago

@PabloKowalczyk done!

PabloKowalczyk commented 2 years ago

Thank you @bashgeek