search

lavas-project / jekyll-pwa

Jekyll plugin for PWA
MIT License
107 stars 19 forks source link

gh-pages support #29

Open bsde1234 opened 5 years ago

bsde1234 commented 5 years ago

Will this gem support gh-pages hosting? Thanks.

torrocus commented 5 years ago

In README.md @xiaoiver wrote that: "This plugin has been used in my blog so that you can see the effect."

At his page PWA works correctly and in Gemfile he uses github-pages.

So theoretically everything works. But looking at the code of his site I have no idea how. He has two branches master and gh-pages and I don't know which one is displayed on xiaoiver.github.io. In my opinion, he doesn't use anywhere jekyll-pwa plugin. There is no proper configuration in the _config.yml file.

souldanger commented 5 years ago

it works on gh-pages - see https://xiaoiver.github.io - which is obviously a GitHub domain...

bsde1245 commented 5 years ago

He may be hosting in gh-pages, but deployed somewhere else like heroku. I think it won't work in gh-pages.