Add enabled flag - Githubissues

lavas-project / jekyll-pwa

Jekyll plugin for PWA

MIT License

107 stars 19 forks source link

Closed julianrubisch closed 4 years ago

julianrubisch commented 4 years ago

To optionally disable sw registering in development, I've added a enabled flag for the config. Thought that'd be a good idea.

souldanger commented 4 years ago

Hi Julian thanks for the commit! Please provide more details.

julianrubisch commented 4 years ago

Should I add a README entry? I wanted to wait for a response whether this is even desired.

I ran into issues when the SW was active locally

Great plugin btw!

souldanger commented 4 years ago

SORRY - I was confident I answered but... yes, please add readme entry.

julianrubisch commented 4 years ago

Sorry it took so long... also, I realized I should default to true so as not to break existing installations 😁