lavavu / LavaVu

Lightweight, Automatable Visualisation & Analysis Viewing Utility
Other
53 stars 12 forks source link

Remove jupyter-server-proxy from dependencies #75

Closed brmather closed 5 years ago

brmather commented 5 years ago
jupyter-server-proxy requires Python '>=3.5' but the running Python is 2.7.15

I think this just involves removing it from requirements.txt. Or make lavavu strictly only compatible with Python versions >3.5...

Nearly everything is Python3 except pyGPlates which is still hanging onto python2 at least until the end of the year. That's how I discovered this.

lmoresi commented 5 years ago

Time to give up on 2.X

The whole jupyter environment is in flux with the shift to 1.0.x releases and many packages are broken. Their ecosystem is too huge for us to deal with maintaining compatibility for different versions.

pyGplates - is it really not possible to grab this and force it into a standard pip / dependency format. If john mansour can do this for underworld, surely it can be done for anything !

I guess this is a public rant now.

L

Prof Louis Moresi

louis.moresi@unimelb.edu.aumailto:louis.moresi@unimelb.edu.au

(w) +61 3 8344 1217

(m) +61 4 0333 1413

(us) +1 505 349 4425

www.moresi.infohttp://www.moresi.info/

www.facebook.com/underworldcodehttp://www.facebook.com/underworldcode

@LouisMoresihttps://twitter.com/LouisMoresi

On 17 Jul 2019, 10:32 PM -0700, Ben Mather notifications@github.com, wrote:

jupyter-server-proxy requires Python '>=3.5' but the running Python is 2.7.15

I think this just involves removing it from requirements.txt. Or make lavavu strictly only compatible with Python versions >3.5...

Nearly everything is Python3 except pyGPlates which is still hanging onto python2 at least until the end of the year. That's how I discovered this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/OKaluza/LavaVu/issues/75?email_source=notifications&email_token=ADABPI5F2ZARRAHRFIQIDCDP7754TA5CNFSM4IEXCOXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G75F3DQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADABPI4PDNVHATJH7EP5IY3P7754TANCNFSM4IEXCOXA.

brmather commented 5 years ago

Yes, it's quite annoying because I have to constantly switch between Python 2.X and 3.X kernels in my notebooks. 2020 cannot come fast enough because then all packages should be Python3 compliant, including pyGPlates.

Re pip installation: unfortunately, pyGPlates has not been decoupled from GPlates so all the compilation with qt4 to build the user interface for GPlates must also be done for pyGPlates. I think if all those pieces are stripped away, then pyGPlates would be a relatively simple installation requiring GDAL, GEOS, pyproj, and a few C++ routines wrapped with Cython. Until then, we have to point the PYTHONPATH to the install directory.

OKaluza commented 5 years ago

This was already fixed, requirements.txt has the following: jupyter-server-proxy; python_version > '2.7' Running pip install -r requirements.txt with python 2.7 responds:

Ignoring jupyter-server-proxy: markers 'python_version > "2.7"' don't match your environment

As it's an optional dependency this is fine, so you can ignore it. Older versions didn't have the condition, so you may have issues with them until you update: I released 1.4.1 today.

brmather commented 5 years ago

Ah! Fantastic, thanks @OKaluza!

lmoresi commented 5 years ago

Our docker builds using the current pypi 1.4.1 kept failing with the error below. But a git+https pip install in the docker file with the latest commit works just fine. See https://cloud.docker.com/u/underworldcode/repository/registry-1.docker.io/underworldcode/stripy/builds/d500bdbf-d9b9-42cc-abba-0f36dc8302b7

Is something strange going on with us or you ?

Complete output from command python setup.py egg_info: Traceback (most recent call last): File "", line 1, in File "/tmp/pip-build-dvncjipk/lavavu/setup.py", line 279, in with open('requirements.txt') as f: FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt' Version matches: 1.4.1 Libraries ['png', 'z'] found and passed compile test Libraries ['tiff'] found and passed compile test

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-dvncjipk/lavavu/

On 17 Jul 2019, 11:01 PM -0700, Owen Kaluza notifications@github.com, wrote:

This was already fixed, requirements.txt has the following: jupyter-server-proxy; python_version > '2.7' Running pip install -r requirements.txt with python 2.7 responds:

Ignoring jupyter-server-proxy: markers 'python_version > "2.7"' don't match your environment

As it's an optional dependency this is fine, so you can ignore it. Older versions didn't have the condition, so you may have issues with them until you update: I released 1.4.1 today.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/OKaluza/LavaVu/issues/75?email_source=notifications&email_token=ADABPI4RGA6DJAYWUI5IS3TQAABJJA5CNFSM4IEXCOXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2HNHFA#issuecomment-512676756, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADABPI4SKBB7KEMCARPRRGDQAABJJANCNFSM4IEXCOXA.

brmather commented 5 years ago

I get the same error message installing from the PyPI repository:

    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-1wk2_kww/lavavu/setup.py", line 279, in <module>
        with open('requirements.txt') as f:
    FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
    Version matches: 1.4.1
    Libraries ['png', 'z'] found and passed compile test
    Libraries ['tiff'] found and passed compile test
    Libraries ['avcodec', 'avformat', 'avutil'] found and passed compile test
    Libraries ['swscale'] found and passed compile test
brmather commented 5 years ago

It could be because requirements.txt is not listed in MANIFEST.in.

OKaluza commented 5 years ago

Yes, there's an update out now