search

laveeshb / azure-function-extensions-net

Extensions for Azure Functions
MIT License
4 stars 7 forks source link

AutoResolve for SQS Extension #35

Closed juanmjacobs closed 4 years ago

juanmjacobs commented 4 years ago

Hi, how are you? This is a great project, thank you very much for sharing it! I'm trying to run the SQS Extension on a JS worker. Could you please add [AutoResolve] for the SQS extension configuration properties? I've noticed that the other extensions have the AutoResolve attribute, but not this one. I think that just adding the attribute would allow a function.json to specify environment variable names instead of hardcoded values.

{
  "disabled": false,
  "bindings": [{
      "name": "message",
      "type": "sqsQueueTrigger",
      "direction": "in",
      "queueName": "myQueue",
      "QueueUrl": "AWS_QUEUE_URL",
      "AWSKeyId": "AWS_KEY_ID",
      "AWSAccessKey": "AWS_ACCESS_KEY"
    }
  ]
}

Thank you for your time!

laveeshb commented 4 years ago

Thank you for your contribution. I'll review your change.

laveeshb commented 4 years ago

@juanmjacobs I have published the package here https://www.nuget.org/packages/AzureFunctions.Extension.SQS/1.1.0. Here are the release notes -- https://github.com/laveeshb/azure-function-extensions-net/releases/tag/amazon.sqs-v1.1.0