lavenderdotpet / LibreQuake

A freesoftware quake one remake with art under the BSD license
https://discord.gg/nsr6DTF6RX
Other
418 stars 34 forks source link

QC: Fix call to `__NULL__` in `teleport_use`, move away from `SUB_Null` macro #100

Closed MotoLegacy closed 9 months ago

MotoLegacy commented 9 months ago

Fixes behaviors when non-clients interact with trigger_teleport via .use causing execution of __NULL__. Also replaces all references of the SUB_Null-> __NULL__ macro with __NULL__ outright, suggested to mitigate confusion.

Also opts into building with -O3, verified that optimizations only cause issues when compiling mutators, which LibreQuake is not.

lavenderdotpet commented 9 months ago

oh i didnt see this

lavenderdotpet commented 9 months ago

image got it to crash in ironwail

MotoLegacy commented 9 months ago

Can you make sure you're not just building and replacing progs.dat? Quakespasm derivatives will always use the progs.dat inside of .pak files, ignoring any attempt to "override" them.

lavenderdotpet commented 9 months ago

image got it to crash in ironwail

so some how theres a phantom progs.dat floating around so this wasnt the issue since i tested it ina new git clone and the bug was fixed

but

theres a new bug monsters dont get teleported when they are meant to

MotoLegacy commented 9 months ago

monster

lavenderdotpet commented 9 months ago

wooo