laverdet / node-fibers

Fiber/coroutine support for v8 and node.
MIT License
3.56k stars 224 forks source link

npm install crashing due to fiber install script #440

Closed mikr13 closed 4 years ago

mikr13 commented 4 years ago

On Windows, Powershell Terminal: fibers@4.0.2 install: node build.js || nodejs build.js

At line:1 char:15 node build.js || nodejs build.js                     ~~ The token '||' is not a valid statement separator in this version.

Why are scripts like these implemented without caring about the compatibility?

laverdet commented 4 years ago

Why are scripts like these implemented without caring about the compatibility?

This line was written in 2011 before nodejs even supported Windows at all. It was added for compatibility with Ubuntu.

Install fibers via cmd.exe and you won't run into problems. This is the same for many other C++ nodejs projects.