search

lavie / runlike

Given an existing docker container, prints the command line necessary to run a copy of it.
Other
1.99k stars 118 forks source link

Ignore inherited labels and env variables #104

Closed reconman closed 2 years ago

reconman commented 2 years ago

Fixes #103

reconman commented 2 years ago

Regarding the approval of workflows, what's the value of this setting?

grafik at https://github.com/lavie/runlike/settings/actions

lavie commented 2 years ago

All outside contributors require approval to run workflows.

reconman commented 2 years ago

All outside contributors require approval to run workflows.

Is that activated on purpose? That means you have to allow the workflow for every PR commit.

lavie commented 2 years ago

Yes, on purpose, so I can see no weird stuff is happening with the repo secrets. Also, contributors can run the tests on their own easily (make test) so it shouldn't really be blocking anyone from submitting a passing PR.

reconman commented 2 years ago

Except make test doesn't run on Windows afaik.

Anyways, I'm done with the changes. You can leave your feedback.

lavie commented 2 years ago

Make definitely works on Windows. But in any case, make test is just a shortcut for poetry run pytest -v

reconman commented 1 year ago

@lavie Could you please increase the version number so my changes are visible?

lavie commented 1 year ago

done.