Closed DDSDerek closed 2 months ago
Cool! Would you kindly add test coverage for this change?
Cool! Would you kindly add test coverage for this change?
FAILED test_runlike.py::TestRunlike::test_network_mode - AssertionError: '--n...
FAILED test_runlike.py::TestRunlike::test_restart_not_present - AssertionErro...
There are currently two errors in the part, but I haven't made any changes, so I can't solve it. Can you help me to solve it?
@lavie I have solved these two problems here. In the latest docker:
@lavie Now the test should pass perfectly.
continued in https://github.com/lavie/runlike/pull/121
In the old code, using
Config.Volumes
andHostConfig.Binds
to get volume can only display volume mounts in bind mode normally. I changed it to get the volume through theMounts
data string, so that bothbind
andvolume
mounting can be obtained normally.