lavinir / hassio-onedrive-backup

MIT License
258 stars 9 forks source link

backup file not removed in HA after upload to onedrive and new backupt created #186

Open eddysteurs opened 7 months ago

eddysteurs commented 7 months ago

since a few days i notice my diskusage going up every time a backup has ran. After investigation is seems addon is not removong older backups from HA (after sync to ondedrive and new backup is created) Addon only mentions or zero (although minimum local is 1) but several files remain in the HA backup folder. In HA system backups nothing is mentioned.

image image image

Have restarted addon, HA, remove and reinstall addon already but problem remains HA is 2024.2.6 Ondedrive addon 2.3

mrkaqz commented 7 months ago

I have the same issue. I have to SSH to remove the file from /backup folder manually. Noticed the back up file did not show in HA backup file list in Settings > System > Backup when reload the UI showing this error in the supervisor logs.

24-02-28 18:46:17 ERROR (MainThread) [supervisor.backups.backup] Can't read backup tarfile /data/backup/28b27c7e.tar: "filename './backup.json' not found"

lavinir commented 7 months ago

The backup deletions happen through the Home Assistant Supervisor API. Are you saying they are still there after deletion? Do you see them in Home Assistant (Settings -> System -> Backups) ?

eddysteurs commented 7 months ago

no they do not appear in system - backups, only in the folder backups, so they don't get deleted, it has been taken by the developper of the supervisor (seems related to size) and should be solved in supervisor 2024.2.1

mrkaqz commented 7 months ago

I noticed that if the backup does not show in HA UI ( Settings > System > Backup) then it mean the backup file was corrupted. It will not regcognized as back up file hence it will not remove automatic.

Mine was cause by MariaDB add-on make the backup file corrupted all the time. If I do backup without MariaDB add-on then it will show up in UI just fine and will get delete as usual.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity.