lavoiesl / osx-cpu-temp

Outputs current CPU temperature for OSX
GNU General Public License v2.0
925 stars 156 forks source link

Print a space between value and unit #22

Closed ad-si closed 5 years ago

ad-si commented 5 years ago

The general rule of the International Bureau of Weights and Measures (BIPM) is that the numerical value always precedes the unit, and a space is always used to separate the unit from the number, e.g. "30.2 °C" (not "30.2°C" or "30.2° C").

lavoiesl commented 5 years ago

LGTM, thanks!

ad-si commented 5 years ago

👍

Did you purposely not merge it yet, or was it an accident? 😅

lavoiesl commented 5 years ago

I thought that with the recent changes to PR reviews, you'd be able to merge your own after my approval 🤷‍♂

ad-si commented 5 years ago

Haha, yeah it's hard to keep up with all the changes. 😂 Thanks for merging!