search

lawinslow / hydrolinks

National Hydrography Network Dataset Tools for R
Other
10 stars 3 forks source link

st_crs warning on linking #22

Closed lawinslow closed 6 years ago

lawinslow commented 6 years ago 
Warning messages:
1: st_crs<- : replacing crs does not reproject data; use st_transform for that 
2: st_crs<- : replacing crs does not reproject data; use st_transform for that 
3: st_crs<- : replacing crs does not reproject data; use st_transform for that

I get this on most linking calls. Is this line necessary anymore? I took a stab at eliminating the warning https://github.com/lawinslow/hydrolinks/pull/21/files#r144973858 I think we can safely just transform the shape before use (shouldn't need to reproject anyway).

@rainshapes thoughts?