lawishere / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

Modifying tags with mp4tags -m "test" corrupts some specific MP4 files #169

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Note this is obviously not a generic problem, it is specific to some specific 
MP4 files.  A test file that this issue is reproducible with is referenced 
below.

What steps will reproduce the problem?
1. Download this specific MP4 file:

https://s3.amazonaws.com/bizmodeller/Staging/test.mp4

2. Run mp4info test.mp4:

c:\mp4v2\bin\Windows-x64\Debug>mp4info test.mp4
mp4info version 2.0-r477
test.mp4:
mp4v2::impl::MP4Atom::ReadAtom: "test.mp4": atom type  is suspect
Track   Type    Info
1       video   H264 High@3, 2484.582 secs, 1068 kbps, 686x344 @ 29.970031 fps
2       audio   MPEG-4 AAC LC, 2484.480 secs, 154 kbps, 48000 Hz
mp4v2::impl::MP4Atom::ReadAtom: "test.mp4": atom type  is suspect
 Name: Amish.Mafia.S03E05.The.Bear
 Encoded with: HandBrake 0.9.9 2013051800
 TV Show: Amish Mafia
 TV Episode: 5
 TV Season: 3

3. Run:

mp4tags -m "test" test.mp4

4. Run mp4info test.mp4 (again):

c:\mp4v2\bin\Windows-x64\Debug>mp4info test.mp4
mp4info version 2.0-r477
test.mp4:
mp4v2::impl::MP4Atom::ReadAtom: "test.mp4": atom type  is suspect
mp4v2::impl::MP4Atom::ReadChildAtoms: "test.mp4": In atom  missing child atom 
moov
mp4v2::impl::MP4File::FindIntegerProperty: no such property - 
moov.mvhd.modificationTime (..\..\src\mp4file.cpp,746)
mp4info: can't open test.mp4

5. The file is now corrupted and unplayable

Note: it does not appear to matter which tag is updated.
Note 2: Performing an optimize before updating the tag allows the tag update to 
succeed without corruption

What is the expected output? What do you see instead?

The expected output is that either MP4Tags/libmp4v2.dll should update the tag 
successfully, or it should not corrupt the file.

What version of the product are you using? On what operating system?

version 2.0-r477 on Windows 8 64-bit

Please provide any additional information below.

A dump of the file using mp4file --dump (prior to tag modification) is attached 
for your reference.

Original issue reported on code.google.com by e...@bizmodeller.com on 13 Apr 2014 at 10:59

Attachments: