lawliet89 / biscuit

JOSE (JSON Web Token) Library for Rust
https://lawliet89.github.io/biscuit
Other
181 stars 35 forks source link

Implement ECDH-ES #74

Open lawliet89 opened 7 years ago

lawliet89 commented 7 years ago

Probably not the AES**KW variants because ring does not seem to support AESKW.

vladikoff commented 6 years ago

is still in the works?

There is some mention of ECDH-ES in the source https://github.com/lawliet89/biscuit/blob/e578b4071fb7315dbe9d84d05b2d81672887151e/src/jwa.rs#L418 , what's currently missing?

lawliet89 commented 6 years ago

Support from the Crypto library (ring) is missing. I haven't had the time to implement it with Openssl instead.

On Thu, 16 Nov 2017, 23:38 Vlad Filippov, notifications@github.com wrote:

is still in the works?

There is some mention of ECDH-ES in the source https://github.com/lawliet89/biscuit/blob/e578b4071fb7315dbe9d84d05b2d81672887151e/src/jwa.rs#L418 , what's currently missing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lawliet89/biscuit/issues/74#issuecomment-344961118, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8APeZzAU7eYuHhjce_0Ea3ITFLAQ1Dks5s3FcEgaJpZM4NFp9F .

-- Regards Yong Wen

briansmith commented 5 years ago

There are two PRs for ring to implement https://github.com/briansmith/ring/issues/331, which would allow this to be implemented using ring, I believe.

lawliet89 commented 5 years ago

Thanks @briansmith for letting me know. I'll keep a lookout.