search

lawndoc / Respotter

MIT License
0 stars 0 forks source link

Fix original usage of sr1 #14

Closed lawndoc closed 3 days ago

lawndoc commented 3 days ago

In #6 we were actually failing to set a Scapy configuration option conf.checkIPaddr = False, which is required when response packets aren't from the destination IP of our request packet. Big thanks to the maintainer of Scapy for pointing that out, because I had missed that in the documentation.

In #12 we applied a workaround, which was using AsyncSniffer to capture the responses. This workaround is no longer needed, and the original sr1 capture works better because it doesn't require manual delays to ensure we are sniffing packets long enough.

lawndoc commented 3 days ago

In troubleshooting the previous issue we had opened, the Scapy maintainer noticed an actual bug with the Netbios responses. This PR should not be merged until https://github.com/secdev/scapy/pull/4445 is merged over in the Scapy project.

lawndoc commented 3 days ago

I'm just gonna merge since we are still troubleshooting other issues. The scapy PR will get merged eventually.