lawnstarter / react-native-picker-select

🔽 A Picker component for React Native which emulates the native <select> interfaces for iOS and Android
https://npmjs.com/package/react-native-picker-select
MIT License
1.75k stars 499 forks source link

Not showing selected value on Android #414

Open matobiely opened 3 years ago

matobiely commented 3 years ago

Describe the bug
I am using picker-select in form for creating/editing notes. I am fetching items from our API.

First issue is with create note:

Issue with edit:

It works fine only if i have items array locally ( not acceptable) and also default value is set to value from items, which is problem for creating new, because default is null. Also it is not accepting default value from props (as can be seen in code snipet)

On iPhone works just fine, only Android issue.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
I expected the same behavior as on iPhone.

Screenshots

  1. Empty new form
image
  1. Show all items
image
  1. Select picker after select one of the items
image

Additional details

Reproduction and/or code sample

function NewNote({ t, note: _note, loading, onSubmit, onCancel }) {
  const [note, setNote] = useState(_note);
  const [categories, setCategories] = useState([]);
  const [categoryId, setCategoryId] = (_note && _note.categoryId );

  const handleSubmit = async () => {
    await onSubmit(note);
    setNote(null);
    onCancel();
  };

  const loadCategories = async () => {
    const res = await axios('categories/autocompletes', {
      params: {
        params: { perPage: 9999 },
        filters: [
          {
            by: 'categoryType',
            rule: 'equal',
            value: 'Note'
          }
        ]
      }
    });

    setCategories(
      res.data.categories.map(c => ({
        value: c.id,
        label: c.name
      }))
    );
  };

  const handleNoteTypeChange = value => {
    if (!value) return;
    setCategoryId(value);
    setNote({ ...note, categoryId: value });
  };

  useEffect(() => {
    loadCategories();
  }, []);

  return (
           <RNPickerSelect
            value={note && note.categoryId}
            onValueChange={handleNoteTypeChange}
            style={_pickerStyles}
            placeholder={{ label: 'Type', value: null }}
            items={categories}
          />
)
EmmanuelSkapple commented 3 years ago

Same error to :/

KIMNIGANG commented 3 years ago

same error too

guozhaolong commented 3 years ago

same error too

iwashi1t commented 3 years ago

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

guozhaolong commented 3 years ago

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

  • style={{ inputAndroid: { color: 'black' } }}
  • useNativeAndroidPickerStyle={false}

verified, inputAndroid: {color:'black' } this trick is easy to use,thx bro

matobiely commented 3 years ago

@iwashi1t Thanks. It helps. But as you mentioned, it is just temporary workaround, it will be great, if somebody from team take a look on it.

iggirex commented 3 years ago

After many hours of twiddling with this thing finally found this thread. Low and behold this indeed does fix the problem!! style={{ inputAndroid: { color: 'black' } }} useNativeAndroidPickerStyle={false}

My other solution was to set the placeholder as empty object, but this screws up the layout if you're needing that placeholder placeholder={{}}

Tharinducn commented 3 years ago

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

  • style={{ inputAndroid: { color: 'black' } }}
  • useNativeAndroidPickerStyle={false}

This didn't fix the issue.

imsjmalve commented 3 years ago

style={{ inputAndroid: { color: 'black' } }} useNativeAndroidPickerStyle={false}

these two perfectly works for me

dschnare commented 3 years ago

I'm having this issue with iOS actually. Tried setting styles for inputIOS with no dice.

const pickerStyles = StyleSheet.create({
  inputIOS: {
    fontSize: 16,
    paddingVertical: 12,
    paddingHorizontal: 10,
    borderWidth: 1,
    borderColor: 'gray',
    borderRadius: 4,
    color: 'black',
    paddingRight: 30 // to ensure the text is never behind the icon
  },
  inputAndroid: {
    fontSize: 16,
    paddingHorizontal: 10,
    paddingVertical: 8,
    borderWidth: 0.5,
    borderColor: 'purple',
    borderRadius: 8,
    color: 'black',
    paddingRight: 30 // to ensure the text is never behind the icon
  }
})
<PickerSelect
  disabled={isSaving}
  Icon={Chevron}
  style={pickerStyles}
  placeholder={{}}
  items={items}
  value={value}
  onValueChange={(value) => setValue(value)}
  useNativeAndroidPickerStyle={false}
  textInputProps={{ style: { borderRadius: 5 } }}
/>
imsjmalve commented 3 years ago

u said useNativeAndroidPickerStyle={false}, find another for iso

ubay1 commented 3 years ago

const [selectedLanguage, setSelectedLanguage] = useState('');

<RNPickerSelect useNativeAndroidPickerStyle={false} value={selectedLanguage} onValueChange={(itemValue) => { setSelectedLanguage(itemValue) }} items={[ { label: 'Football', value: 'football' }, { label: 'Baseball', value: 'baseball' }, { label: 'Hockey', value: 'hockey' }, ]} >

{selectedLanguage }

ubay1 commented 3 years ago

hey, lets try..

EvgeniiKlepilin commented 3 years ago

One thing that I found was that if you have a default Android Theme, it usually has a default application-wide font color set to #ffffff. You can change that by either adding a custom font color to existing theme, or changing parent theme to themes like MaterialDark or Holo for example.

android/app/src/main/res/values/styles.xml

    <!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="android:textColor">#000000</item>
        <item name="android:statusBarColor">@color/black</item>
    </style>

android/app/src/main/AndroidManifest.xml

    <application
      android:name=".MainApplication"
      android:label="@string/app_name"
      android:icon="@mipmap/ic_launcher"
      android:roundIcon="@mipmap/ic_launcher"
      android:theme="@style/AppTheme">

References:

It seems that there are some native parts of this package that can be changed by tweaking details of the manifest.

Saurabhreactninja commented 3 years ago

style={{ inputAndroid: { color: 'black' } }} useNativeAndroidPickerStyle={false}

these two perfectly works for me

Which version of picker_select you are using ?

JedrzejMajko commented 2 years ago

Regarding iOS and Android I encounter similar issue when padding (in inputIOS or )inputAndroid was set to large number, like 20 on ios 14 or lower. on ios 15 vertical padding of 20+ didn't cause same issue. So this can also be a styling issue coming from label being out of view.

This is iOS 14 with inputIOS.paddingVertical 10:
Screenshot 2022-04-11 at 11 38 21

This is iOS 14 with inputIOS.paddingVertical 18:
Screenshot 2022-04-11 at 11 38 55