search

lawrahkonwea / My-portfolio

This a portfolio website I created using HTML, CSS and JavaScript. It has UI features like aminations, transitions and modal. The portfolio includes all works I have done, projects I have created and opportunities I am looking out for.
MIT License
4 stars 0 forks source link

Fix responsiveness issue on 1140px screen size #23

Closed sweep-ai[bot] closed 1 year ago

sweep-ai[bot] commented 1 year ago

Description

This PR fixes the responsiveness issue on the 1140px screen size in the My-portfolio repository. The portfolio was not properly responsive at this screen size, causing layout and display problems. This PR modifies the CSS media queries to handle the 1140px screen size and ensures that all elements respond as expected.

Summary of Changes

Fixes #22.

To checkout this PR branch, run the following command in your terminal:

git checkout sweep/fix-responsiveness-issue

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

netlify[bot] commented 1 year ago

Deploy Preview for amakalaurakonwea ready!

Name Link
Latest commit e871ad8e42ac30d4f3028cd49c9d6754b80b53e9
Latest deploy log https://app.netlify.com/sites/amakalaurakonwea/deploys/65033f371df48300084496ae
Deploy Preview https://deploy-preview-23--amakalaurakonwea.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 46   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 50   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 52   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

sweep-ai[bot] commented 1 year ago

🚀 Wrote Changes

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 46   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 50   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 52   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

Hi @sweep-ai[bot],

I decided to make the following changes:

File Path Proposed Changes
index.html Modify index.html with contents:
• Add 'rel="noopener"' to all anchor tags with 'target="_blank"'.
style.css Modify style.css with contents:
• Find the unclosed CSS block and close it.
sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

sweep-ai[bot] commented 1 year ago

🚀 Wrote Changes

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

Hi @sweep-ai[bot],

I decided to make the following changes:

File Path Proposed Changes
index.html Modify index.html with contents:
• Add 'rel="noopener"' to all anchor tags that have 'target="_blank"'.
style.css Modify style.css with contents:
• Identify the unclosed CSS block and close it properly.
sweep-ai[bot] commented 1 year ago

🚀 Wrote Changes

The command that failed is npx hint .. Here are the relevant lines from the logs:

line 48   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 54   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 79   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 81   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 83   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 85   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 87   col 17  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener
line 90   col 11  Hint     Button type attribute has not been set.                                                                                                                          button-type
line 90   col 39  Error    Link 'rel' attribute should include 'noopener'.                                                                                                                  disown-opener

The command npx stylelint "**/*.{css,scss}" also failed. Here is the relevant line from the logs:

218:3  ✖  Unclosed block   CssSyntaxError

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

Hi @sweep-ai[bot],

I decided to make the following changes:

File Path Proposed Changes
index.html Modify index.html with contents:
• Add 'rel="noopener"' attribute to all anchor tags that have 'target="_blank"' attribute.
style.css Modify style.css with contents:
• Identify the unclosed CSS block and close it properly.
sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The command that failed is npx stylelint "**/*.{css,scss}". Here are the relevant lines from the logs:

style.css
218:3  ✖  Unclosed block   CssSyntaxError

Please note that the line numbers may vary depending on the actual content of the file.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.