search

lawrancej / CompilerKit

Compiler construction library in C.
GNU Lesser General Public License v2.1
55 stars 33 forks source link

Nice to have extended alternation #42

Closed lapatink closed 12 years ago

lapatink commented 12 years ago

Hey Joey,

I finished the variable list argument for alternation. I have a couple todos that could make it better but need to wait till i finish my other issues. I also have some questions for you about how the regex should work and about the test files.

As a note, I had to change the old function to return a GObject instead of a CompilerKitAlternation Object to really work. I know that was another issue that someone was working on, but I had to do it myself.

-Kyle

lawrancej commented 12 years ago

I'm merging in your changes, but until there are tests for the changes, it'll be on a separate branch, issue42and28.

I noticed that alternation.h had the old prototype for the alternation_vlist_new, and fixed that. Also, with Daniel's changes to concatenation, I went ahead and fixed a few things here and there so your changes play nicely with his changes.

lawrancej commented 12 years ago

Well, even though I merged the extended alternation into master, it still needs a test or (at the very least) a demo.

By the way, I fixed the EmptySet issue. Turns out that implementing singleton in GObject isn't as straightforward as it would be in Java. http://blogs.gnome.org/xclaesse/2010/02/11/how-to-make-a-gobject-singleton/