search

lawremi / CustomOreGen

Custom Ore Generation mod for Minecraft, originally by JRoush
Artistic License 2.0
41 stars 25 forks source link

1.12 Branch #199

Closed Draco18s closed 4 years ago

Draco18s commented 7 years ago

Not sure what branch of the base I point the PR at.

Anyway, here's the changes I made to get COG running on 1.12

Used HasSky -> hasSkyLight, still unsure about that one.

Biome names changed to registry names (fortunately not many were affected beyond an enforcement to lower case). BOP thankfully used the same string for both the name and the registry name.

lawremi commented 6 years ago

Sorry for leaving this for so long. Could you just reissue this against the master branch? For some reason it is against the 1.10 branch, which of course causes all sorts of conflicts.

Draco18s commented 6 years ago

I can't do it right away, but soon. I've recently relocated and haven't set up my computer yet.

lawremi commented 6 years ago

Hi Draco,

Just a reminder about this. I think all that's needed is some button clicks in GitHub. Then we can get a 1.12 version out. Thanks!

Draco18s commented 6 years ago

Thanks for the reminder, my life's been chaos.