search

lawremi / CustomOreGen

Custom Ore Generation mod for Minecraft, originally by JRoush
Artistic License 2.0
40 stars 25 forks source link

feature request: seperate mod ore gen config from main mod #201

Open mvdhoning opened 6 years ago

mvdhoning commented 6 years ago

Can the ore generation configs be seperated from the mod?

Custom configs for third party mods could then be a community effort seperated from the main mod. Might speed up maintaineabilty (keeping up with changes in other mods) and put even more effort in development of the main part of the mod ore generation what it already does a good job at.

Now the mod comes with outdated configs and configs for mods the might not even be part of the modpack custom ore gen is part of.

Maybe the xml configs for mods as now can be published as template holders.

It now feels that the configs are holding back a release to 1.12 as the 1.12 build from draco18s proves the main part of the mod is already doing a great job in minecraft 1.12. Yes the configs for 3rd party mods are a bit outdated but fixeable by the community there is already been effort done in that part, but seems to be hard to make a way into the code to generate the xml config file.

Having the config seperated form the main mod would also allow other mod makers to supply xml ore gen config for their mod e.g. for harder ores. Or from others in form of an addon mod.

lawremi commented 6 years ago

There's no reason why the community cannot contribute right now to the built-in configs. Maybe we should just punt on the whole XML generation and just maintain the XML files directly, like we did before. Mod makers can already supply their own configs by copying them into the right directory.

mvdhoning commented 6 years ago

Me for one, has no idea how the generation thing works and how what i should provide to you to get a fixed generated xml. Changing a xml file is doable.

lawremi commented 6 years ago

It is kind of ironic that the Sprocket system was designed to make generating configs more user friendly, and now it appears to be a barrier. Is the documentation at https://github.com/lawremi/Sprocket not clear? Or is the tool hard to get working? I'll gladly accept pull requests to the INI files under the configs/Examples/Standard and configs/Examples/Strategic directories. I can then run Sprocket to generate the XML and push the changes into this repository.

mvdhoning commented 6 years ago

The documentation is clear enough, now that i found it :-) Just to many configurable things like with the xml files ;-) . For me python is a bit of barrier as i dont have it installed (yet), so editing the ini files would be a 'blind' job.

Maybe i am to used to working with xml, but i cannot judge for others here.

Just a side thought: could the COG mod be made to read the ini files directly?

lawremi commented 6 years ago

I've thought about reading the ini files, and it's probably a good idea. That's not something I'll get to anytime soon, but I'd welcome a contribution for that.