1.14 - Githubissues

lawremi / CustomOreGen

Custom Ore Generation mod for Minecraft, originally by JRoush

Artistic License 2.0

41 stars 25 forks source link

1.14 #235

Closed Draco18s closed 4 years ago

Draco18s commented 4 years ago

Tons more fixes and updates to make the code compatible with 1.14

All the distributions still need work (some changes were made here, likely not even correct, things need to compile before I can validate and adjust).

Things I can't fix at this time:

ConfigErrorDialog (something to do with LWJGL on Mac)
BlockDescriptor (relies on a fast-match using numeric IDs)
CustomPacketPayload, CustomPacketPayloadHandler (networking has been radically altered and I don't even know what this does).

lawremi commented 4 years ago

I think we might be stepping on each other's toes here. I think I've fixed a lot of these already (months ago); now we have conflicts. Please sync up and resolve them. Btw, I fixed the networking stuff, at least to the point that it compiles. Thanks for continuing to push on this.

Draco18s commented 4 years ago

Hmm. I made sure what I had was up to date with your git repo before. I did anything.

Unless....oh, I wonder if it was a branch thing. I have a 1.14 branch, which is what I thought was going into your master previously. Grump. I'll chew on git layer today to see what happened.

Draco18s commented 4 years ago

Yep, that's what it was. My branch was badly behind and I couldn't tell.