IanSudbery
commented
10 years ago I can confirm this.
The function 'getLimitsFromScales' takes each scale and tests if it has a "limits" entry. If it does it tests if its aesthetics contain either the x* or y* aesthetics and creates a res object based on which it is.
Of course a fill (or color) scale has a limits entry, but no x or y related aesthetics, so no res object is ever created.
Presumably a good fix would be:
function (obj)
{
scal <- obj$scales$scales
lst <- lapply(scal, function(x) {
if (!is.null(x$limits)) {
res <- NULL
limits <- x$limits
if (any(x$aesthetics %in% c("x", "xmin", "xmax",
"xend", "xintercept", "xmin_final", "xmax_final"))) {
res <- data.frame(xmin = limits[1], xmax = limits[2],
ymin = NA, ymax = NA)
}
if (any(x$aesthetics %in% c("y", "ymin", "ymax",
"yend", "yintercept", "ymin_final", "ymax_final"))) {
res <- data.frame(ymin = limits[1], ymax = limits[2],
xmin = NA, xmax = NA)
}
}
else {
res <- NULL
}
res
})
lst <- lst[!is.null(lst)]
res <- do.call("rbind", lst)
res <- data.frame(xmin = min(res$xmin[!is.na(res$xmin)]),
xmax = max(res$xmax[!is.na(res$xmax)]), ymin = min(res$ymin[!is.na(res$ymin)]),
ymax = max(res$ymax[!is.na(res$ymax)]))
res
}
tengfei
gehrenk
I've encountered what seems like a bug when attempting to set color or fill scales in two different tracks. Basically, I would like both tracks to have the same color limits so they can be directly compared, but when I try to do this and then display them both using tracks() it does not work.
Example using the test data from the vignette (gr): track1 <- autoplot(gr, aes(fill=value))+ scale_fill_continuous(low="blue", high="red", limits=c(0, 200)) track2 <- autoplot(gr, aes(fill=score))+ scale_fill_continuous(low="blue", high="red", limits=c(0, 200))
Both display as expected when I plot them individually, but when I combine them:
tracks(track1, track2)
I get the error:
Error in FUN(X[[2L]], ...) : object 'res' not found
Seems like this should be possible, as it is very useful to be able to compare similar data on the same scale. Is this a bug, or am I missing something?
Thanks, Gretchen