search

lawremi / ggbio

Grid and ggplot2 based visualization for biological data
111 stars 24 forks source link

user-facing classes not exported #50

Open lawremi opened 10 years ago

lawremi commented 10 years ago

Please export any classes meant to be user-facing (like GGbio, Tracks?) from the NAMESPACE. We need this for ReportingTools (@gmbecker). Thanks!

gmbecker commented 10 years ago

To be more concrete, GGbio (an S4 class) appears in an export statement, but NOT an exportClass statement, meaning packages cannot import only the class.

lawremi commented 10 years ago

The current export of GGbio of course refers to the constructor function.

On Thu, Mar 20, 2014 at 8:25 AM, Gabe Becker notifications@github.comwrote:

To be more concrete, GGbio (an S4 class) appears in an export statement, but NOT an exportClass statement, meaning packages cannot import only the class.

Reply to this email directly or view it on GitHubhttps://github.com/tengfei/ggbio/issues/50#issuecomment-38180576 .

gmbecker commented 10 years ago

Ah, I saw ggbio() in there and that seemed to be the constructor so I didn't look for one called GGbio. Turns out they are identical so I was half right.

~G

On Thu, Mar 20, 2014 at 9:23 AM, lawremi notifications@github.com wrote:

The current export of GGbio of course refers to the constructor function.

On Thu, Mar 20, 2014 at 8:25 AM, Gabe Becker <notifications@github.com

wrote:

To be more concrete, GGbio (an S4 class) appears in an export statement, but NOT an exportClass statement, meaning packages cannot import only the class.

Reply to this email directly or view it on GitHub< https://github.com/tengfei/ggbio/issues/50#issuecomment-38180576>

.

Reply to this email directly or view it on GitHubhttps://github.com/tengfei/ggbio/issues/50#issuecomment-38188209 .

Gabriel Becker Graduate Student Statistics Department University of California, Davis