search

lawremi / rtracklayer

R interface to genome annotation files and the UCSC genome browser
Other
28 stars 17 forks source link

Improved platform independence via curl_version_info() #126

Closed sanchit-saini closed 2 months ago

sanchit-saini commented 3 months ago

Fix #123

lawremi commented 3 months ago

This is a runtime check, but it needs to be a compile time check in order to solve #123. Use the C preprocessor to compare the 7.59.0 to LIBCURL_VERSION_NUM. Also, please isolate the conditional to just selecting between CURLINFO_FILETIME and CURLINFO_FILETIME_T, i.e., do not repeat the calls to the curl function. It is easy to do this with the preprocessor.

sanchit-saini commented 3 months ago

@lawremi Updated it. Can you review it.