search

lawrence-laz / neotest-zig

Test runner for Zig in Neovim using Neotest backend.
MIT License
27 stars 7 forks source link

automatic releases and luarocks/rocks.nvim support? #28

Closed mrcjkb closed 3 months ago

mrcjkb commented 4 months ago

Hey :wave:

rocks.nvim has the ability to install luarocks packages and automatically install dependencies, including tree-sitter parsers.

I was wondering: Would you be open to automating releases and publishing this plugin to luarocks.org? See also our wiki page on plugin support.

I'd be more than happy to help if you have any questions or issues.

lawrence-laz commented 3 months ago

Hi,

I am not against it, but I don't use luarocks myself, so I am unlikely to find the time to set this up and maintain it.

If some user of both neotest-zig and rocks.nvim were to take up the ownership and maintenance of this process, then a PR would be welcome. :)

mrcjkb commented 3 months ago

I'm a rocks.nvim maintainer and also maintain neotest-haskell. So I could open a PR if you like. I'd recommend you add the luarocks API key yourself though. I don't think it's a good idea to give strangers access to repo secrets :). Another option would be just to add the release-please workflow here and to move luarocks publishing to the NURR.

lawrence-laz commented 3 months ago

Is the release-please workflow needed only for an automated git tag and/or github release? Does the NURR not work with manual releases?

mrcjkb commented 3 months ago

NURR searches for SemVer git tags. It doesn't matter if they were created automatically or not.

lawrence-laz commented 3 months ago

Makes sense. I've been needlessly prefixing tags with v, but otherwise they follow semver. So I'll just drop the prefix and all should be good, right?

mrcjkb commented 3 months ago

The prefix is ignored by the luarocks workflow, so you can keep it if you want :) If I add it to the NURR, there's nothing for you to do here and you can close this issue.