Conform to the SAML Schema

lawrencepit / ruby-saml-idp

SAML Identity Provider library in ruby

MIT License

137 stars 102 forks source link

Conform to the SAML Schema #9

Closed ismell closed 6 years ago

ismell commented 10 years ago

TheInResponseTo is optional. If it's not specified we should not render it because it will fail schema validation.

naiyt commented 6 years ago

Beyond failing specs / merge conflicts, is there anything preventing this from being merged? I've run into a situation where this has caused a problem. (I would probably also recommend pulling the logic around the InResponseTo out of the long assertion / xml strings.)

naiyt commented 6 years ago

Tagging @lawrencepit (since I'm not sure if GitHub would send a notification otherwise)

naiyt commented 6 years ago

Just saw that the commit got pulled into 0.3.4, thanks!