lawruixi / pe

0 stars 0 forks source link

Phone Numbers shouldn't be restricted to Eight Digits #3

Open lawruixi opened 1 year ago

lawruixi commented 1 year ago

Phone numbers, as specified in the UG, can only be eight digits. Any attempt to add a phone number not consisting of eight digits, for instance: customer add --name Name --phone 123456789 --email abc@def --address address

...is met with the error message:

Phone numbers should only contain numbers, and it should be 8 digits long.

However, phone numbers may not be eight digits long, especially overseas. Hence, is this overzealous input validation? Perhaps a warning could be displayed instead of blocking the input entirely.

nus-pe-bot commented 1 year ago

Team's Response

This bug report would be accepted, however, it would be a documentation bug instead as the UG was not specific enough in stating that the rationale for eight digits is because we only want Singapore phone numbers as we are catering only for Singapore customers with Singapore phone number.

Screenshot 2023-11-20 at 10.48.40 AM.png

Furthermore, our examples all state Singapore addresses and Singapore phone numbers, thus, we always had it in mind that we the customers are from Singapore but did not state it down explicitly.

photo_2023-11-20 10.51.11.jpeg

photo_2023-11-20 10.50.17.jpeg

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]