search

laws-africa / laws-africa.github.io

https://laws.africa/
MIT License
1 stars 2 forks source link

Embed video on homepage #44

Closed musangowope closed 2 years ago

musangowope commented 2 years ago

resolves https://github.com/laws-africa/laws-africa.github.io/issues/43

longhotsummer commented 2 years ago

Pls take a look at https://getbootstrap.com/docs/5.0/helpers/ratio/ -- we need the iframe to be responsive, otherwise the mobile view it's truncated on the sides.

longhotsummer commented 2 years ago

Nice use of bootstrap tabs to toggle :)

musangowope commented 2 years ago

Pls take a look at https://getbootstrap.com/docs/5.0/helpers/ratio/ -- we need the iframe to be responsive, otherwise the mobile view it's truncated on the sides.

Note we are currently using bootstrap 4.4.1, meaning we don't have access to ratio utility classes so I created my own class to wrap around the iframes and enforce aspect ratio of 16:9

https://www.loom.com/share/b56d642e752e43bab4fba8aa58277a7a

longhotsummer commented 2 years ago

Pls take a look at https://getbootstrap.com/docs/5.0/helpers/ratio/ -- we need the iframe to be responsive, otherwise the mobile view it's truncated on the sides.

Note we are currently using bootstrap 4.4.1, meaning we don't have access to ratio utility classes so I created my own class to wrap around the iframes and enforce aspect ratio of 16:9

https://www.loom.com/share/b56d642e752e43bab4fba8aa58277a7a

V4 has https://getbootstrap.com/docs/4.0/utilities/embed/

longhotsummer commented 2 years ago

But your solution works great!