Document nature is now required

[longhotsummer]

This ensures that all documents have a descriptive nature, even those without a subtype. For example, all Legislation objects now default to "Act". This means we can rely on the nature as a database-indexed description of the type of every document.

This makes it possible to facet on the nature. Before, we had to facet on a weird mixture of doc_type and nature.

In future, nature will be preferred over doc_type in search results. But we need to backfill the nature field in ES for that to work.

Other:

• makes faceting code support (value, label) tuples so that labels can be different to values and can take translation into account
• pulls countries out of fixtures/documents/sample_documents.json so it's easier to manage

Example by-law listing:

Example general legislation listing:

Outstanding

• [x] if possible, a mechanism to backfill elasticsearch documents to ensure they all have a nature, so we can stop using doc_type with search
• [x] filter facets must be able to have different values and labels, so that the label can be "Act" but the value is "act"

[longhotsummer]

Closes https://github.com/laws-africa/peachjam/issues/815

[github-actions[bot]]

Test Results

48 tests   48 :white_check_mark:  11s :stopwatch: 13 suites   0 :zzz: 13 files     0 :x:

Results for commit ae59d108.

:recycle: This comment has been updated with latest results.

[longhotsummer]

@actlikewill this is ready for review

[sentry-io[bot]]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ IntegrityError: duplicate key value violates unique constraint "peachjam_documentnature_name_key" peachjam.migrations.0152_backfill_natures in fo... View Issue
• ‼️ FieldError: Unsupported lookup 'code' for ForeignKey or join on the field not permitted. /judgments/{code}/{registry_code}/ View Issue

_{Did you find this useful? React with a 👍 or 👎}