search

lawtancool / pyControl4

Python 3 asyncio package for interacting with Control4 systems
https://lawtancool.github.io/pyControl4
Apache License 2.0
38 stars 16 forks source link

Add support for blinds. #11

Closed brunchboy closed 2 years ago

brunchboy commented 2 years ago

This works great with the blinds in my home, further confirming that your library is compatible with Director OS 2.0.

I ran your suggested flake8 linter, and it only complained about long lines (no longer than were found in the existing lights.py that I based this on, however, so I thought they were probably fine), and ran Black to fix up the format (there was one missing and one extra blank line).

This is a re-created version of PR #10 with email properly configured so the commit is signed and verified. If you accept it, it fixes issue #9.

lawtancool commented 2 years ago

@brunchboy This PR looks really good! Thanks for creating nice comments for each of the functions and following the existing code style.

I just added one comment about seeing whether we could figure out the range of the battery level reporting. If not, that's ok, I'll just merge leaving it as is.

Also, interesting observation about the library working with OS 2 systems. I would have thought that the REST API we're using here was introduced alongside the OS 3-exclusive mobile apps. I'll add a note to the README.