Changed alot to coding best practices

[MatthiasWeier]

used var get rid of unnecessary brackets using lambda expressions invert ifs Instead of "namespace{ }" use "namespace;" Didnt had the time to do everything manual.

[ScrubN]

get rid of unnecessary brackets using lambda expressions

This makes refactoring more difficult, no thanks

used var Instead of "namespace{ }" use "namespace;"

I have deliberately avoided doing this because it destroys the blame.

I appreciate the concern, but I'm familiar with how the codebase is right now and this will just make me need to relearn nearly everything. Thanks but no thanks.

[ScrubN]

Okay! I atleast suggest inverting ifs. Because that actually makes the code faster.

Inverting ifs doesn't change the AST of the code - it will compile exactly identically.

And more readable

I will use TimeDuration.Parse as an example.

public static TimeDuration Parse(string str)
{
    if (string.IsNullOrWhiteSpace(str))
    {
        throw new FormatException();
    }

    if (str.Contains(':'))
    {
        var timeSpan = TimeSpan.Parse(str);
        return new TimeDuration(timeSpan);
    }

    var multiplier = GetMultiplier(str, out var span);
    if (decimal.TryParse(span, NumberStyles.Number, null, out var result))
    {
        var ticks = (long)(result * multiplier);
        return new TimeDuration(ticks);
    }

    throw new FormatException();
}

In this code, the precedent is set that a new TimeDuration struct is returned by both of the parsing branches, and if that is not successful then an exception is thrown.

public static TimeDuration Parse(string str)
{
    if (string.IsNullOrWhiteSpace(str))
        throw new FormatException();

    if (str.Contains(':'))
    {
        var timeSpan = TimeSpan.Parse(str);
        return new TimeDuration(timeSpan);
    }

    var multiplier = GetMultiplier(str, out var span);
    if (!decimal.TryParse(span, NumberStyles.Number, null, out var result))
        throw new FormatException();

    var ticks = (long)(result * multiplier);
    return new TimeDuration(ticks);
}

When you inverted the last if, you not only broke that precedent but also made it more difficult to add more parsing conditions in the future.