lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.77k stars 261 forks source link

Show Twitch Markers in the final vod. #1259

Open JollyFan opened 1 day ago

JollyFan commented 1 day ago

Checklist

Write your feature request here

Hi, I've been enjoying using the TwitchDownloader for my VODs and I've been happily surprised it stores the change of games in the metadata of the file (i suppose). Doing so in my editing video software it comes automatically marked giving me a huge time saving. This said.. I'm also someone that used Twitch Markers a bit.. Would it be possible to implement a similar thing to storing the time a game changed BUT for twitch markers? Thanks

ScrubN commented 1 day ago

I looked into fetching markers once but was unsuccessful. I can try taking another look though.

ScrubN commented 1 day ago

Good news: I successfully figured out how to fetch markers. Bad news: I don't have the time to implement it right now, so you'll have to wait a while :(

ScrubN commented 1 day ago

Also, how should I go about adding markers to the video metadata? Should I require the user to choose between either games or markers as the video chapters, or should I apply both at the same time?

For example, mixed chapters may look like:

  1. Just Chatting
  2. Minecraft
  3. Minecraft: Marker name
  4. Minecraft: Marker name
  5. Just Chatting
  6. Just Chatting: Marker name

or they could look like:

  1. Just Chatting
  2. Minecraft
  3. Marker name
  4. Marker name
  5. Just Chatting
  6. Marker name

Personally, I'm a fan of the first example, possibly with a - instead of a : though. Would appreciate your feedback on that.

Another issue, how should I handle nameless markers? Should I just call the chapter Marker or maybe Marker by Username?

JollyFan commented 1 day ago

Hi, thank you for the quick response! For what they could be useful for me, I'd like to have them both.. games and markers at the same time, rather than 1 or the other. I agree on liking the first example, it's more detailed and doesn't leave the user wondering. ( - better than : imo). About nameless markers, Wich are probably going to be the most common ones (many of us have automations with stream deck and streamer not and they mostly do description less markers), you could go with a: "Marker", "Generic Marker". Anyhow thanks a lot for taking the time looking into this.

Mishasama commented 6 hours ago

Another issue, how should I handle nameless markers? Should I just call the chapter Marker or maybe Marker by Username?

I recommend using timestamps.

  1. Minecraft - 10:24
  2. Minecraft - 20:48
  3. Minecraft - <Marker name>
  4. Minecraft - 1:23:45
  5. Just Chatting - 2:34:56
  6. Just Chatting - <Marker name>
ScrubN commented 6 hours ago

I recommend using timestamps.

  1. Minecraft - 10:24
  2. Minecraft - 20:48
  3. Minecraft - <Marker name>
  4. Minecraft - 1:23:45
  5. Just Chatting - 2:34:56
  6. Just Chatting - <Marker name>

I don't like the idea of timestamps because each chapter already has timestamps associated with it for video players and editors. Adding timestamps to the name of a game change chapter seems redundant. image