Subscriber Notifications / Highlights - Githubissues

lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay

MIT License

2.7k stars 260 forks source link

Subscriber Notifications / Highlights #347

Closed goldbattle closed 1 year ago

goldbattle commented 2 years ago

Checklist

[X] I have checked the issue page for duplicates
[X] I am running the latest version (download here)

Describe your issue here

The highlight messages don't seem to be working in the pre-release 1.50.0 for me. Was originally added way back here: https://github.com/lay295/TwitchDownloader/issues/19 Testing at 1:33 into this VOD are the below results. 1553966638_example.json.txt

What I see in 1.50.0 (the text seems to go out of bounds also):

What I see in 1.40.7:

The message has the correct notice param:

"user_notice_params":{"msg-id":"resub"}

lay295 commented 1 year ago

Yeah, kinda forgot about it when rewriting the rendering code.

Added it back now and fixed it. Looks like the twitch chat API is no longer letting us know when it's a sub message though with the v5 API, and in the new GQL query they're using it doesn't tell us anything either.

I just guess if it's a sub message now since the API is no longer telling us. I still have to double check if it tells us if it's a highlighted message. If they're not telling us it's a sub message anymore I doubt it though.

https://github.com/lay295/TwitchDownloader/blob/59741ffad607fea3b49eadc279ccbd70200c9ffa/TwitchDownloaderCore/ChatRenderer.cs#L386-L393