lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.75k stars 262 forks source link

Mark VODs with muted Sections #679

Open TheMadog24 opened 1 year ago

TheMadog24 commented 1 year ago

Checklist

Write your feature request here

With the new chapters and metadata feature added to the video and the chat .json file, I think it would be nice to mark the Muted sections of the video, if possible (using the embedded chapters and json chapters section).

I'm not sure if you have the ability to see that information, I know the VOD has it marked on the timeline, so i assume there is a way to pull that data.

My other suggestion would be to try and grab the unmuted version of the VOD if possible, with the m3u8 file, as described in issue #182, as I know it is still possible to do this with most VODs, I have personally tested it.

ScrubN commented 1 year ago

With the new chapters and metadata feature added to the video and the chat .json file, I think it would be nice to mark the Muted sections of the video, if possible (using the embedded chapters and json chapters section).

I'm not sure if you have the ability to see that information, I know the VOD has it marked on the timeline, so i assume there is a way to pull that data.

I'm pretty sure there can only be 1 set of chapters in a video file. Choosing one or the other, I would rather have the game chapters.

My other suggestion would be to try and grab the unmuted version of the VOD if possible, with the m3u8 file, as described in issue #182, as I know it is still possible to do this with most VODs, I have personally tested it.

When did you last personally test it? Because the other day I downloaded a vod mere minutes after ending and was only able to get a quarter of the muted chunks as unmuted. Twitch no longer takes 24 hours to purge unmuted chunks from the API.

TheMadog24 commented 1 year ago

When did you last personally test it? Because the other day I downloaded a vod mere minutes after ending and was only able to get a quarter of the muted chunks as unmuted. Twitch no longer takes 24 hours to purge unmuted chunks from the API.

I last tested it today. I was able to successfully download a video that had a muted segment. The video was 6 days old when I downloaded it, it only had 1 muted segment, but I was able to download it unmuted. Although, I do know that it's not always the case, and there have been some videos that I cannot get unmuted, even immediately after the VOD goes live, it seems random. Perhaps the more muted segments, the less of a chance for a successful unmute? or maybe it has to do with the content that was muted?

All of my attempts have been with in-game music from games, not from normal songs or anything, and the success rate seems to be about 80% for me.

EDIT: I am leaning more towards the ladder suggestion of it being the type of muted audio. My reasoning is that when I was streaming, some times the in-game music would get flagged and auto muted on my vods, but I was able to make an appeal. Sometimes, that appeal was successful, because twitch just mutes anything it thinks might not be ok. Sometimes those appeals take a week or longer, so they must have to keep those sections for longer, in the case of a successful appeal, and unmute them.