lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.75k stars 262 forks source link

Chat Update does not do anything if the Vod is expired #790

Closed TheMadog24 closed 1 year ago

TheMadog24 commented 1 year ago

Checklist

Edition

Windows GUI Application

Describe your issue here

I have old VODs and Chat files from before the Badges API V1 shutdown. These files are also from before the option was added to embed the badges, so I wanted to update them to get the badges and bits added.

However, it does not seem to do so. It just spits out ERROR: Unable to find thumbnail: Video is expired or embedded ID is corrupt and then completes. It seems to only add in a blank "video" section, and does not attempt to retrieve any badges or bits.

image

I assumed it would do this, just go through and grab the comments badges and bits, and add them in. Is this not a functionality? Does it need a video/VOD to still be live?

if so, can this be changed/added? The program I made that uses these also used the API V1, and with that gone, I was relying on the embedded data. thanks.

Add any related files or extra information here

No response

ScrubN commented 1 year ago

Could you upload the chat file? The updater is fetching the badges as expected on my end.

TheMadog24 commented 1 year ago

Could you upload the chat file?

I renamed them from .json to .txt so they could be uploaded here, just remember to rename them back.

Before: Removed

After: Removed

image

TheMadog24 commented 1 year ago

Nevermind, I apologize.

I unchecked and re-checked the option to replace Embeds, and it works now.

ScrubN commented 1 year ago

Yeah I was about to say, it seems to be working fine. image

I did find an unrelated problem though that I might fix.