search

lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.6k stars 260 forks source link

Search clips by category (game) #812

Open SalvaDope opened 11 months ago

SalvaDope commented 11 months ago

Checklist

Write your feature request here

Hello,

Is it possible to search clips by category/game? you can search by channel, but it would be really nice if you could also set the category link and search clips from different streamers on the same category/game.

Thanks, this is a beautiful tool!

ScrubN commented 11 months ago

I have a working proof of concept, however the current mass downloader UI needs a bit of a rework to be compatible.

Unfortunately due to limitations, the user will not be able to search for categories and instead be required to browse categories similarly to https://www.twitch.tv/directory. This is because each category has a special API name and it is simply much easier this way. Maybe in the future we will think of a solution to this problem, but for now this is how it will be.

ScrubN commented 11 months ago 
          And please add the streamer language selection setting in this menu

Originally posted by @artsimonenkov in https://github.com/lay295/TwitchDownloader/issues/734#issuecomment-1596112823

SalvaDope commented 11 months ago

thank you for the reply @ScrubN, browsing for categories feels good enough already :)

can you ping me here when this is implemented please?

thank you!

ScrubN commented 8 months ago

@SalvaDope A bit of update on this.

Unfortunately pagination is not working. That means we can only fetch the first handful of items and no more. I could compromise by increasing the size of the handful to 90 or so, but I am worried that users might complain that it looks like it should be possible to fetch more when it just isn't, and Twitch might also notice that we are fetching far more items in a single request than the website (which pulls 30 at a time).

If only seeing the top 90 categories works for you though, then I will be fine with that and continue with implementing the feature.

SalvaDope commented 8 months ago

@ScrubN thank you for the reply.

I'll be honest with you, I don't fully understand the pagination/handful concepts so I can't really help in suggesting a solution :(

But to answer you, the top 90 categories is already more than fine!

I just don't want you nor the software to get in "trouble" for requesting too much from twitch. If you feel it's a safe maneuver to test, let's go :)

Thank you for your work, it's really a great piece of software