lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.72k stars 260 forks source link

No halloween emotes in the chat render #879

Closed Nutri626 closed 11 months ago

Nutri626 commented 1 year ago

Checklist

Edition

Unsure

Describe your issue here

Hello, many streamers added halloween emotes lately and program simply does not recognize them to render it, in previous years chat was rendered with halloween emotes but with latest versions it renders as "normal" (same will happen to new year emotes and stuff)

Add any related files or extra information here

No response

sunkhaskasis commented 1 year ago

Hint: always provide the VOD the next time you're having issues with emotes.

With that said, I know you're referring to Forsen's channel in particular, so I think I know why TD doesn't render his halloween emotes. If you take a look at his BTTV page, you'll notice that his editor hasn't removed the regular emotes and just lumped them together with the halloween versions. Essentially, what this means is that there are duplicate emotes under the same name. This most likely confuses TD, so it fetches whatever first image it can find and ignores the other. I tried downloading Forsen's most recent VOD and rendering chat on my end, but it doesn't display the halloween emotes. Moreover, it doesn't even fetch them if you have a look inside the cache folder.

Personally, I'd say this is not a bug with the TD, but rather the issue is the way Forsen's editors have decided to handle halloween emotes.

Nutri626 commented 1 year ago

Hint: always provide the VOD the next time you're having issues with emotes.

With that said, I know you're referring to Forsen's channel in particular, so I think I know why TD doesn't render his halloween emotes. If you take a look at his BTTV page, you'll notice that his editor hasn't removed the regular emotes and just lumped them together with the halloween versions. Essentially, what this means is that there are duplicate emotes under the same name. This most likely confuses TD, so it fetches whatever first image it can find and ignores the other. I tried downloading Forsen's most recent VOD and rendering chat on my end, but it doesn't display the halloween emotes. Moreover, it doesn't even fetch them if you have a look inside the cache folder.

Personally, I'd say this is not a bug with the TD, but rather the issue is the way Forsen's editors have decided to handle halloween emotes.

yeah i knew that would be problem that caused it, case closed i guess

ScrubN commented 1 year ago

Apologies for this issue not having a simple solution. You can get around it by only embedding the emotes from the provider you want to take priority, then using the chat updater with "embed missing" to embed the rest of the emote providers to the chat.

I was working on a patch to allow the user to specify emote provider priority, however it relied on upgrading to .NET7 which didn't work out and by the time I went back to try porting it to .NET6 instead, many files had moved and it was just a huge pain.

Selectable emote priority is still planned functionality (see #476), but I'm a little burned out from this project after #880 so I'm probably going to take a short break.

Nutri626 commented 11 months ago

Screenshot_9

Apologies for this issue not having a simple solution. You can get around it by only embedding the emotes from the provider you want to take priority, then using the chat updater with "embed missing" to embed the rest of the emote providers to the chat.

I was working on a patch to allow the user to specify emote provider priority, however it relied on upgrading to .NET7 which didn't work out and by the time I went back to try porting it to .NET6 instead, many files had moved and it was just a huge pain.

Selectable emote priority is still planned functionality (see #476), but I'm a little burned out from this project after #880 so I'm probably going to take a short break.

priority wont help this problem cos both are bttv (normal and christmas emotes for example), reason im reopening this topic is that i just realized even program like chatterino is generating christmas emotes over regular ones, i asked pajlada about it and here is the answer, basically only fix of it would be if program somehow prioritizes newly added emotes over old ones maybe you can look into it how i can be done for twitch downloader aswell? idk ..

https://github.com/Chatterino/chatterino2/blob/44abe6b487272ec11f0e5f2cd05e7bd635b0bddc/src/providers/bttv/BttvEmotes.cpp#L153-L160

p.s

just asked mod and he removed duplicate emotes which ofc fixed the problem but for the future it still would be a good feature to have if its even possible, gonna close this again