lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.64k stars 260 forks source link

im an idiot and idk how to use the macos app or set it up and yes i read the readme getting started for macos #892

Closed estrobink8 closed 4 months ago

estrobink8 commented 9 months ago

Checklist

Write stuff here

see title, i would greatly appreciate it if someone could take a moment who knows what they're talking about to explain to me how to set up & use this program on macos with apple silicon. thanks so much and have a great day or night!

ScrubN commented 9 months ago

We do not yet have an Apple Silicon Arm64 binary since none of the contributors own Apple Silicon devices, however you should be able to run the Intel x64 binary with Rosetta. According to online sources, you can run the command arch -x86_64 zsh to start a new terminal session running under Rosetta, and from there you should be able to run TwitchDownloaderCLI via the session.

If you are having trouble with using CLI apps, please see if https://github.com/lay295/TwitchDownloader/issues/789#issuecomment-1689230243 helps.

Please let me know if you are able to run the Intel x64 binary with Rosetta and I will add this extra step to the README.

estrobink8 commented 9 months ago

heres a screen recoreding of the issue im running into.

ScrubN commented 9 months ago

Is your terminal open to the directory containing TwitchDownloaderCLI? The FFmpeg download command should have printed some things to the console.

Also in reference to the end of the video, since TwitchDownloaderCLI is not in your PATH environment variable, your command needs to invoke it with ./TwitchDownloaderCLI.

estrobink8 commented 9 months ago

im sorry idk what any of that means

estrobink8 commented 9 months ago

wdym directory containing TwitchDownloaderCLI & TwitchDownloaderCLI is not in your PATH environment variable, your command needs to invoke it with ./TwitchDownloaderCLI?

ScrubN commented 9 months ago

wdym directory containing TwitchDownloaderCLI

When you open a terminal, it defaults to your user folder: /usr/<you>/, or ~ for short. Let's say TDCLI is in a directory in your downloads folder: /usr/<you>/Downloads/TwitchDownloaderCLI-1.53.4/TwitchDownloaderCLI (or ~/Downloads/TwitchDownloaderCLI-1.53.4/TwitchDownloaderCLI).

You must use the cd command to change the current directory that your terminal is in from your user directory to the directory in your Downloads: e.g. cd ~/Downloads/TwitchDownloaderCLI-1.53.4. From there, you should be able to invoke TDCLI with the relative-path commands provided in the README.

TwitchDownloaderCLI is not in your PATH environment variable, your command needs to invoke it with ./TwitchDownloaderCLI?

At the end of the video, you ran TwitchDownloaderCLI videodownload --id .... Since TwitchDownloaderCLI isn't part of the magic string that turns executable names into commands (called PATH), you need to write out the preceding ./: ./TwitchDownloaderCLI videodownload --id ....

estrobink8 commented 9 months ago

oh i see. it worked thank you!

ScrubN commented 9 months ago

Can you please confirm if chat rendering works too? You need to download a chat beforehand then pass that into the renderer. ./TwitchDownloaderCLI chatdownload --id 1980309083 --output chat.json ./TwitchDownloaderCLI chatrender --input chat.json --output chat.mp4

ScrubN commented 9 months ago

Hmmm. My best guess is that it is a problem with running FFmpeg under Rosetta. We setup FFmpeg differently for the chat renderer, so if that works as expected then I have an idea that might fix the video downloader under Rosetta too.

estrobink8 commented 9 months ago

nevermind the vod actually has that res i didnt watch it beforehand

ScrubN commented 9 months ago

Does that mean the stretching is just a problem with the screenshot?

estrobink8 commented 9 months ago

no the actual vod has that res

estrobink8 commented 9 months ago

i will confirm the chat thing tomorrow

ScrubN commented 9 months ago

I downloaded your VOD as well and the stretching is not present. The blockiness however is related to how the VOD was streamed. image

estrobink8 commented 9 months ago

weird when i go to the vod on twitch and click on the source quality option it shows this:

Screenshot 2023-11-20 at 8 37 43 AM
ScrubN commented 9 months ago

Interesting, it might be a problem with MacOS then.

SputNikPlop commented 9 months ago

@ScrubN I have a mac with silicon and it indeed is a macos problem that I was able to reproduce. I've found golang and rust work better on cross compilation but getting something like this to work for mac would take a considerable amount of effort.

estrobink8 commented 9 months ago

chat rendering works, sorry i forgot to do that days ago lol

ScrubN commented 9 months ago

Actually, instead of adding Rosetta instructions to the README, I could just add a binary for apple silicon. Would you be willing to test it out? https://github.com/lay295/TwitchDownloader/actions/runs/7026613707

You should not need to use the arch command before running this. My only concerns are that the colors in chat renders might be mixed up, and the FFmpeg binary downloaded through TwitchDownloaderCLI may not work?

estrobink8 commented 9 months ago

https://github.com/lay295/TwitchDownloader/assets/43555540/d4e10491-7712-43be-a6b7-65208335f998

SputNikPlop commented 9 months ago

Actually, instead of adding Rosetta instructions to the README, I could just add a binary for apple silicon. Would you be willing to test it out? https://github.com/ScrubN/TwitchDownloader/releases/tag/1.53.5

You should not need to use the arch command before running this. My only concerns are that the colors in chat renders might be mixed up, and the FFmpeg binary downloaded through TwitchDownloaderCLI may not work?

This is working better for at least downloading on my apple silicon machine, I haven't had time to full test.

estrobink8 commented 9 months ago

i cant get it set up as you can see in the video, howd you do it?

ScrubN commented 9 months ago

i cant get it set up as you can see in the video, howd you do it?

You forgot to navigate your terminal to the directory containing TwitchDownloaderCLI. cd Downloads/TwitchDownloaderCLI

estrobink8 commented 9 months ago

in what step do i put the cd part?

SputNikPlop commented 9 months ago

in what step do i put the cd part?

Right after you open a new terminal window do cd Downloads

estrobink8 commented 9 months ago

um

image
estrobink8 commented 9 months ago
image
estrobink8 commented 9 months ago

nvm i just had to use /Users/mrbonk/twitchdlder as the pathname not /Users/mrbonk/twitchdlder/TwitchDownloaderCLI

estrobink8 commented 9 months ago

ugh now this @SputNikPlop

image
SputNikPlop commented 9 months ago

ugh now this @SputNikPlop image

I installed ffmpeg outside the command, unsure which binary is the best since it has been so long. Maybe someone else might know or I can follow up later.

ScrubN commented 9 months ago

ugh now this

When you get the message "zsh: killed" it means it did not recognize the command. In this case, it is because you are typing the name of TwitchDownloaderCLI, not invoking it. To invoke, you type ./<filename> <args>, which would look like ./TwitchDownloaderCLI ffmpeg --download in the case of downloading FFmpeg. You got everything else correct though!

I installed ffmpeg outside the command, unsure which binary is the best since it has been so long. Maybe someone else might know or I can follow up later.

Installing FFmpeg through homebrew is better for the entire system, but having a built in FFmpeg downloader allows us to provide a prebuilt binary that definitely supports the compilation feature flags we require, and it also makes it easier for beginners as its just 1 command.

estrobink8 commented 9 months ago
image

im sorry but its still not working. what am i doing wrong now?

ScrubN commented 9 months ago

Have you run chmod +x TwitchDownloaderCLI on it yet? That command enables execution for that file and must be run at least once before invoking.

estrobink8 commented 9 months ago

i have

estrobink8 commented 9 months ago

bump @ScrubN

ScrubN commented 9 months ago

I'm sorry, but I do not know what is the problem. If you navigated to the correct directory, ran chmod +x TwitchDownloaderCLI, and correctly invoked TDCLI, then it should be working.

estrobink8 commented 9 months ago

well it randomly started working with this version. maybe it was because i was on beta software.