lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.59k stars 260 forks source link

Clips get stuck at 100% - never finish and then when I cancel it, it gives this error. #906

Closed brettsloan closed 8 months ago

brettsloan commented 8 months ago

Checklist

Edition

Windows GUI Application

Describe your issue here

I paste in all my clip links (About 15). I am only downloading the videos, not chat. I set all the Parallel Task Limits to 1.

Everything seems fine but the video gets stuck at 100% (I waited while testing for over an hour) and doesn't move on to the next clip in the queue.

When I hit cancel, it shows that the download failed. When I click the error button, this comes up (Verbose errors are on).

image

I'm pretty computer savvy but I couldn't understand what was being used to prevent it from downloading. Maybe I'm doing something wrong.

Any help or tips is greatly appreciated.

Add any related files or extra information here

This is the first clip in the list but they all did the same thing. https://www.twitch.tv/inabox44/clip/ObliviousFastFoxRalpherZ-HbbK2blKzipiYDGt?featured=false&filter=clips&range=all&sort=time

ScrubN commented 8 months ago

Thank you for mentioning that the problem is related to the task queue. None of the other reports have mentioned this.

ScrubN commented 8 months ago

Can you please see if the workflow build from github.com/lay295/TwitchDownloader/actions/runs/7025281065 solves your issue?

brettsloan commented 8 months ago

Going to try it now. I originally downloaded the GUI one so I'll test that first.

brettsloan commented 8 months ago

The issue seems to persist even in the new build

Screenshot 1 of everything going well but this is where it stays. It's been about 5-10 minutes now and it should definitely be done. image

Second screen shot is of me hitting cancel - it says Status: Failed and the next one begins image

and here's the error: image

ScrubN commented 8 months ago

It's times like these where I wish the task queue showed the exact status of what is happening...

Can you test if it happens outside of the task queue too?

brettsloan commented 8 months ago

I'll try now.

So the download was quite quick but it's been stuck on the metadata portion for about 2 minutes without moving at all. Looks like that might be the culprit image

brettsloan commented 8 months ago

Tried with 'Encode Metadata' turned off and it just gave me this error image

ScrubN commented 8 months ago

Tried with 'Encode Metadata' turned off and it just gave me this error image

Check task manager for any open instances of ffmpeg.exe. If you find any, kill the processes then try again.

brettsloan commented 8 months ago

funnily enough, I just closed/reopened everything and re-tried with metadata turned off and it seems like it worked! Not sure about the 0% thing in the lower right hand corner

image

Clip is in the appropriate area in 1080p so that's amazing. Maybe add an Encode Metadata checkbox for the queue as well?

ScrubN commented 8 months ago

It seems there is a bug in .NET that leads to a lockup when calling process.WaitForExitAsync() after a process has already exited. The reason the process has already exited is more than likely because FFmpeg could not be started.

I will push another commit that should fix the issue but it would be nice if you could still test it for me.

brettsloan commented 8 months ago

I will gladly! Should I try manually opening FFmpeg while it's running?

ScrubN commented 8 months ago

The new workflow build will be at https://github.com/lay295/TwitchDownloader/actions/runs/7025711638 shortly.

brettsloan commented 8 months ago

Got the new version, went straight into the queue after setting preferred paths and options. Seems to be working like a charm now! They go to 100%, say finished and then move on. image

my issue has been fixed :)

ScrubN commented 8 months ago

Maybe add an Encode Metadata checkbox for the queue as well?

I really want to rework the entire UI so we don't have to deal with multiple ways of queuing, but maybe I'll consider changing some things.

brettsloan commented 8 months ago

Sounds good! let me know if you need a tester for stuff LOL