Building from source fails/gives an error with kick-support branch

taimi7364 commented 6 months ago

Checklist

[X] I have checked the issue page for duplicates
[X] I am running the latest version (download here)

Edition

Windows GUI Application

Describe your issue here

I have .NET 6.0.417 (x64 version) I'm trying to download and render chat from kick stream (https://kick.com/video/3bb8e883-a454-4ba6-866b-c6baea3147d2).

~~I'm trying to build kick-support branch from source but it gives an error: C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\VideoPlatforms\Kick\Downloaders\KickChatDownloader.cs(272,17): warning CS0162: Unreachable code detected [C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\TwitchDownloaderCore.csproj]~~

And when the building is finished it won't download kick chats. The error it gives to me: Unable to get Video/clip information. Please double check your link and try again

Verbose error:

The same happens when I try to build the CLI version.

What I do:

C:\Users\Timi>where dotnet
C:\Program Files\dotnet\dotnet.exe

C:\Users\Timi>cd downloads

C:\Users\Timi\Downloads>cd kicktest

C:\Users\Timi\Downloads\kicktest>git clone --branch kick-support --single-branch https://github.com/lay295/TwitchDownloader.git
Cloning into 'TwitchDownloader'...
remote: Enumerating objects: 5653, done.
remote: Counting objects: 100% (5653/5653), done.
remote: Compressing objects: 100% (1411/1411), done.
Receiving objects: 100% (5653/5653), 28.89 MiB | 16.13 MiB/s, done.sed 0

Resolving deltas: 100% (4385/4385), done.

C:\Users\Timi\Downloads\kicktest>cd TwitchDownloader

C:\Users\Timi\Downloads\kicktest\TwitchDownloader>dotnet restore

Welcome to .NET 6.0!
---------------------
SDK Version: 6.0.417

Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
  Determining projects to restore...
  Restored C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore.Tests\TwitchDownloaderCore.Tests.csproj (in 15.28 s
  ec).
  Restored C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\TwitchDownloaderCore.csproj (in 15.28 sec).
  Restored C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCLI\TwitchDownloaderCLI.csproj (in 15.28 sec).
  Restored C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\TwitchDownloaderWPF.csproj (in 22.55 sec).

C:\Users\Timi\Downloads\kicktest\TwitchDownloader>dotnet publish TwitchDownloaderWPF -p:PublishProfile=Windows -p:DebugType=None -p:DebugSymbols=false
MSBuild version 17.3.2+561848881 for .NET
  Determining projects to restore...
  Restored C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\TwitchDownloaderWPF.csproj (in 8.16 sec).
  1 of 2 projects are up-to-date for restore.
C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\VideoPlatforms\Kick\Downloaders\KickChatDownloader.cs(272,17):
 warning CS0162: Unreachable code detected [C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\TwitchDownloaderCo
re.csproj]
  TwitchDownloaderCore -> C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\bin\Debug\net6.0\TwitchDownloaderCor
  e.dll
  Successfully created package 'C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderCore\bin\Debug\TwitchDownloaderCore
  .1.1.6.nupkg'.
  TwitchDownloaderWPF -> C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\bin\Debug\net6.0-windows\win-x64\Twitc
  hDownloaderWPF.dll
  C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\\Curl-Impersonate\curl-ca-bundle.crt
  C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\\Curl-Impersonate\libcurl.a
  C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\\Curl-Impersonate\libcurl.dll
  C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\\Curl-Impersonate\libcurldll.a
  4 File(s) copied
  TwitchDownloaderWPF -> C:\Users\Timi\Downloads\kicktest\TwitchDownloader\TwitchDownloaderWPF\bin\Release\net6.0-windows\publish\win
  -x64\

C:\Users\Timi\Downloads\kicktest\TwitchDownloader>

I have tried this also on VM but the same thing happens there.

When trying to build master branch it works and no errors are shown.

Add any related files or extra information here

No response

ScrubN commented 6 months ago

It seems the build configuration regarding the Curl libraries is wrong and they are placed in the directory Curl-Impersonate. If you move them from that directory to the directory where TwitchDownloaderWPF.exe is contained, it will work.

The same happens when I try to build the CLI version.

Kick support isn't fully implemented for the CLI yet.

ScrubN commented 4 months ago

Sorry, I have no clue why I closed this without resolving the base issue.

lay295 / TwitchDownloader