search

lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.68k stars 261 forks source link

Queue issue #990

Closed krowgoat closed 6 months ago

krowgoat commented 6 months ago

Checklist

Write stuff here

Just downloaded this after I found out that TwitchLeecher died. How does the Task Queue work? I looked up a streamer and selected a video to download. It did its work, but, just hung at 100% (kept saying "running"). The file is there in the folder I put it in, but it's nothing. What did I do wrong? Also, if I try to delete whatever was downloaded, it says I can't because it's open in ffmpeg. If I restart my computer, I can delete it. What am I doing wrong? (Apologies ahead if I'm an idiot.) Thanks!

superbonaci commented 6 months ago

Because probably it's converting output.ts to output.mp4?

krowgoat commented 6 months ago

So, just wait for a while until it's done?

krowgoat commented 6 months ago

FWIW, yup. Waiting did the trick. Should've been more patient.

superbonaci commented 6 months ago

You had the issue because the last step does not display percentage:

[STATUS] - Finalizing Video... [5/5]

This is because there are cases where the percentage is above 100% or below 0% so it displays the 3 dots all the time instead.

Maybe the program should calculate the percentage based on file size instead the current way. A new bug has been submitted: https://github.com/lay295/TwitchDownloader/issues/991

ScrubN commented 6 months ago

It did its work, but, just hung at 100% (kept saying "running").

This is strange, when the percent issue occurs its supposed to report 0% instead of 100%.

krowgoat commented 6 months ago

Agreed. If it did while it was converting, that would be a nice step. On Sunday, March 17th, 2024 at 6:02 AM, superbonaci @.***> wrote:

You had the issue because the last step does not display percentage:

[STATUS] - Finalizing Video... [5/5]

This is because there are cases where the percentage is above 100% or below 0% so it displays the 3 dots all the time instead.

Maybe the program should calculate the percentage based on file size instead the current way. A new bug has been submitted: #991

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

superbonaci commented 6 months ago

@krowgoat maybe that's an issue with the specific ID. if you could tell which one it was.

krowgoat commented 6 months ago

Do you mean which Twitch streamer?

Sent with Proton Mail secure email.

On Tuesday, March 19th, 2024 at 7:04 AM, superbonaci @.***> wrote:

@.***(https://github.com/krowgoat) maybe that's an issue with the specific ID. if you could tell which one it was.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

superbonaci commented 6 months ago

@krowgoat we've found the issue happens with all videos. https://github.com/lay295/TwitchDownloader/issues/991