lay295 / TwitchDownloader

Twitch VOD/Clip Downloader - Chat Download/Render/Replay
MIT License
2.68k stars 261 forks source link

Add `Audio Only` & `Worst` options to task queue preferred quality #994

Closed ScrubN closed 2 months ago

ScrubN commented 6 months ago
          Please add "Audio Only" option to the task queue.

Originally posted by @ZeusLT in https://github.com/lay295/TwitchDownloader/issues/955#issuecomment-1983985427

Prerequisites:

ScrubN commented 6 months ago

In order to achieve this, we should probably move the current file extension guessing from CLI to Core so we aren't hard coding in the enqueuer: https://github.com/lay295/TwitchDownloader/blob/1afcc3ce2166ab128cb6ca0463fae46acc2e59b5/TwitchDownloaderCLI/Modes/DownloadVideo.cs#L50-L58 https://github.com/lay295/TwitchDownloader/blob/1afcc3ce2166ab128cb6ca0463fae46acc2e59b5/TwitchDownloaderWPF/WindowQueueOptions.xaml.cs#L477-L480

superbonaci commented 6 months ago

I think the whole file extension guessing is something done only on Windows, and generally speaking it shouldn't matter. quality should be the only way to set what has to be downloaded, any file extension or none at all.

ScrubN commented 6 months ago

FFmpeg uses the file extension to automatically determine several things.

ScrubN commented 6 months ago

After #998, we may as well add the "worst" keyword to the enqueuer as well.