layday / instawow

World of Warcraft add-on manager CLI and GUI
GNU General Public License v3.0
153 stars 9 forks source link

AppImage hangs on close #138

Closed zJoul closed 1 month ago

zJoul commented 7 months ago

Hello,

The appimage won't launch, with a cryptic error :

proot error: '/tmp/.mount_instawc5sHYC/usr/bin/python3' not found (root = /, cwd = /tmp, $PATH=(null))
fatal error: see `proot --help`.

Version used : 3.1.0 (on the release page)

Tried on two different machine, same result. At first, I thought it was a problem with the deps for the AppImage, but I tried with the ajour AppImage and it was working fine.

I guess it's linked to the linuxdeploy-plugin-zzzinstawowwebkit2gtk.sh script since this is the only reference to proot but I'm not familiar with appimage bundling (?)

layday commented 7 months ago

Hi, thanks for the report. Could you try the version from https://github.com/layday/instawow/actions/runs/6853292779?

zJoul commented 7 months ago

It launch :tada: But when I try to close it, it hangs… and I need to kill it manually (both the appimage process, and the /tmp/.mountXXXX/ stuff) but it's maybe unrelated

(I don't have any WoW folder on this computer, so no config was done, only launch and close)

torkus commented 7 months ago

it's a stretch, but @zJoul are you executing this from within /tmp in each case? perhaps try /tmp/foo ?

@layday , do you remember when I once tried instawow and it bugged out immediately because I was running it from /tmp ?

update: yeah, this is easy to recreate:

$ wget https://github.com/layday/instawow/releases/download/v3.1.0/instawow-gui-3.1.0-x86_64.AppImage
$ chmod +x instawow-gui-3.1.0-x86_64.AppImage 
$ ./instawow-gui-3.1.0-x86_64.AppImage 
proot error: '/tmp/.mount_instaw6NGYHT/usr/bin/python3' not found (root = /, cwd = /tmp, $PATH=(null))
fatal error: see `proot --help`.
$ echo $?
1

moving it to /tmp/foo doesn't help though, so it's a different problem:

$ mkdir foobar
$ mv instawow-gui-3.1.0-x86_64.AppImage foobar/
$ cd foobar/
$ ./instawow-gui-3.1.0-x86_64.AppImage 
proot error: '/tmp/.mount_instawbZp2G5/usr/bin/python3' not found (root = /, cwd = /tmp/foobar, $PATH=(null))
fatal error: see `proot --help`.

Hi, thanks for the report. Could you try the version from https://github.com/layday/instawow/actions/runs/6853292779?

this one works for me

But when I try to close it, it hangs…

same. instawow-gui -> Quit instawow-gui hangs, ctrl-c from cli works to kill it.

ctrl-c from within gui also hangs. Feels like the gui is capturing the signal, killing the gui but isn't propagating it up to the app.

layday commented 7 months ago

Thanks for cross-checking. Could either of you give https://github.com/layday/instawow/actions/runs/6919535217 a try?

torkus commented 7 months ago

Launches, but instawow-gui -> Quit instawow-gui still hangs.

layday commented 1 month ago

I plan on retiring the app images which are massive and way too much trouble to get working correctly with WebKit2 (the whole image has to be proot'ed!) and replacing them with flatpaks. The current release is the last one with app images. They shan't be missed I expect.

torkus commented 1 month ago

breakdown of downloads: https://somsubhra.github.io/github-release-stats/?username=layday&repository=instawow&page=1&per_page=10

seems like the majority of your downloads comes from the windows world, those .msi and pc-windows-msvc.zip but it's a pretty even spread across formats.

Any idea on download numbers for nix?

layday commented 1 month ago

Unsure but I doubt it’s more than a handful. The majority of downloads come from PyPI: https://www.pepy.tech/projects/Instawow

layday commented 1 month ago

Addressed in https://github.com/layday/instawow/commit/77e95d71a6101195a8804d7c4e1e3b84d5f62223.